Merged
Conversation
- Added #drainResolve field to signal when all tasks are drained - Updated #returnClient() to signal drain completion when closing - Updated close() to wait for tasks before closing clients - Added test to verify close() waits for both in-flight and queued tasks Fixes part of redis#3152
- Added guard check in execute() to reject with ClientClosedError when #isClosing or !#isOpen - All entry points (execute, sendCommand, ping, multi, etc.) are protected since they all funnel through execute() - Added tests verifying execute(), sendCommand(), ping(), and multi().exec() all reject appropriately Fixes part of redis#3152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adresses several pool issues. Some of those were mentioned in #3152
Namely: