RI-8277 Migrate rdi instance pipeline header to i18n#6222
Merged
Conversation
Contributor
Code Coverage - Frontend unit tests
Test suite run success7829 tests passing in 865 suites. Report generated by 🧪jest coverage report action from 91e852f |
pawelangelow
previously approved these changes
Jul 17, 2026
Route the RDI instance pipeline header through i18n under rdi.instance.* with Bulgarian translations: the deploy modal (confirm title, errors warning, overwrite/flush texts, reset checkbox + info, Deploy button), the start/stop/reset pipeline buttons (tooltips, aria-labels, labels), the current pipeline status title and the state labels (initial sync / streaming / not running / error), and the config-file action menu items (download deployed / import ZIP / save ZIP). Pipeline state labels resolve via the i18n singleton inside getStatusToShowFromState (called at render). The v1 status fallback (capitalized raw status) and shared rdiErrorMessages factory are left for the pipeline-management PR. bg: "Deploy"->"Внедряване", "snapshot"->"снапшот". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
valkirilov
force-pushed
the
fe/feature/RI-8277/i18n-rdi-instance
branch
from
July 17, 2026 14:32
e4b8c2c to
899e4ff
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 899e4ff3bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address review feedback: getStatusToShowFromStatus (used for the status-shape badge when pipelineState is absent) built labels via capitalize(status), leaving mixed-language output (e.g. Bulgarian header next to English "Started"/"Ready"). Map the known PipelineStatus values to rdi.instance.status.* keys resolved at render; unknown/arbitrary statuses keep the capitalized fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pawelangelow
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Routes the RDI instance pipeline header through i18next under
rdi.instance.*, with Bulgarian translations added toen.json/bg.json(parity kept). Second of the rdi PRs for the i18n epic (RI-8269); a follow-up coverspipeline-management.Covered:
Testing
yarn testforredisinsight/ui/src/pages/rdi/instance— 114 tests pass.yarn lint:ui,yarn type-check,yarn i18n:checkall clean.?lang=bgto preview Bulgarian.Closes RI-8277
🤖 Generated with Claude Code
Note
Low Risk
Presentation-only i18n refactor with no changes to pipeline actions or backend calls; minor note that status labels in
utils.tsuse the globali18ninstance so they stay in sync on language switches.Overview
Moves hardcoded copy on the RDI instance pipeline header into i18next under
rdi.instance.*, with matching entries inen.jsonandbg.json.Deploy modal, start/stop/reset controls (labels, tooltips, aria-labels), pipeline status title and state/status labels, and the config ZIP menu now call
useTranslation()ori18n.t()instead of inline English. Status helpers replacecapitalize(status)with aSTATUS_LABEL_KEYSmap so everyPipelineStatushas a defined translation key.No deploy/start/stop/reset behavior or API usage changes—strings and localization wiring only.
Reviewed by Cursor Bugbot for commit 91e852f. Bugbot is set up for automated code reviews on this repo. Configure here.