Split FieldsSchemaEditor into smaller components#6217
Open
saidake wants to merge 9 commits into
Open
Conversation
pawelangelow
requested changes
Jul 17, 2026
pawelangelow
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good - nice clean split, and simple is better IMO. The one thing I'd like before we merge is tests for the new components and the extracted logic; that's really the win from isolating them like this.
Contributor
Author
|
hi @pawelangelow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the value decoder
FieldsSchemaEditorinto smaller components.FieldRow(including size-source handling)RepeatBlockEditorFieldsSchemaEditoras the orchestration layer for add/remove/reorder and nested editingIncrease the timeout of a test in
redisinsight/ui/src/pages/browser/BrowserPage.test.tsx, as I encountered a UI CI timeout error:Testing
The Value Decoder field schema continues to work as before:

Note
Low Risk
UI-only refactor of the value decoder schema editor with extracted pure mutation helpers and new unit tests; no API or security surface changes.
Overview
Refactors the value decoder
FieldsSchemaEditorby pulling UI and state logic out of one large file while keeping behavior the same.Field editing moves to
FieldRowandFieldSizeEditor(name, type, fixed vs custom size, size-from-field refs). Repeat blocks useRepeatBlockEditor, which renders nested schema editing viachildreninstead of callingFieldsSchemaEditorfrom inside the repeat component. Add/remove/reorder and field/repeat updates go throughuseSchemaEditorand exported pureapply*helpers (covered byuseSchemaEditor.spec.ts).toNumericOptions(numeric ref select labels, including duplicate-name disambiguation) is centralized inschemaUtilswith unit tests.BrowserPage.test.tsxgets a 10s timeout on one tooltip test.Reviewed by Cursor Bugbot for commit 3c91ce3. Bugbot is set up for automated code reviews on this repo. Configure here.