Graduate server 8.8#529
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7629595bad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Experimental]Note
Medium Risk
Promotes a large set of time-series and search APIs to stable contracts and removes experimental compiler warnings; behavior is unchanged but consumers lose NRS002 guardrails and must target Redis 8.8+ for multi-aggregate usage.
Overview
Graduates Redis 8.8 time-series APIs so they are stable public surface:
[Experimental]/ diagnostic NRS002 is removed fromTsAggregations, multi-valueTimeSeriesTuple.Create/ indexer, and the related range command overloads that takeTsAggregations.Those members move from
PublicAPI.Unshipped.txtintoPublicAPI.Shipped.txt(no more[NRS002]annotations). BuildNoWarnno longer suppresses NRS002.Experimentsdrops theServer_8_8constant, records NRS002 as a retired id (with NRS001), and updatesUrlFormatto.../exp/{0}for future experimental features.Several search APIs that were still unshipped (
Warningson result types,AggregationRequest.AddScores,VectorSearchMethod.NearestNeighbour) are also promoted to shipped in the same pass.Reviewed by Cursor Bugbot for commit 7629595. Bugbot is set up for automated code reviews on this repo. Configure here.