Skip to content

Remove benchmark-operator references, rename templates, and remove kata workloads#1192

Open
arpsharm wants to merge 1 commit intomainfrom
remove-benchmark-operator-references
Open

Remove benchmark-operator references, rename templates, and remove kata workloads#1192
arpsharm wants to merge 1 commit intomainfrom
remove-benchmark-operator-references

Conversation

@arpsharm
Copy link
Copy Markdown
Member

@arpsharm arpsharm commented Apr 15, 2026

Type of change

  • enhancement

Description

All workloads (stressng, uperf, hammerdb) have been migrated to native Kubernetes. This PR removes all dead benchmark-operator code, renames template files to clean conventions, removes kata workloads, renames PIN_NODE_BENCHMARK_OPERATOR to PIN_NODE0, and fixes the oc.py grep→jsonpath issue for pod/VMI detection.

Deleted

  • benchmark_runner/benchmark_operator/ directory (entire operator code path)
  • Old ripsaw CRD templates (stressng_pod/vm, uperf_pod/vm)
  • Operator test files and docs (build_fedora_benchmark_operator.md)
  • All kata golden test files

Edited

  • main.py — removed operator routing and imports
  • environment_variables.py — removed kata workloads, changed fallback namespace to benchmark-runner, namespace resolution reorder (dict first, NAMESPACE fallback)
  • template_operations.py — skip standard template if file doesn't exist
  • oc.py — replaced -o name | grep with -o jsonpath for both pod and VMI detection, removed operator comments
  • Dockerfiles, CI workflows — removed operator version/clone steps
  • Renamed stressng_pod_job_templatestressng_pod_template, stressng_vm_direct_templatestressng_vm_template, uperf_vm_direct_templateuperf_vm_template
  • Renamed PIN_NODE_BENCHMARK_OPERATORPIN_NODE0 across all files (env vars, CI workflows, docs, ES metadata)
  • Updated develop.md and HOW_TO.md — removed operator sections, updated examples
  • Added ES integration test for native workloads (test_elasticsearch_operations_workloads.py)

@openshift-ci openshift-ci bot requested review from RobertKrawitz and gqlo April 15, 2026 13:32
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arpsharm
Once this PR has been reviewed and has the lgtm label, please assign robertkrawitz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arpsharm arpsharm force-pushed the remove-benchmark-operator-references branch from 98267b2 to 330c69a Compare April 15, 2026 13:40
@arpsharm arpsharm requested a review from ebattat April 15, 2026 13:45
@arpsharm arpsharm force-pushed the remove-benchmark-operator-references branch 2 times, most recently from 102c249 to f080785 Compare April 15, 2026 15:21
Copy link
Copy Markdown
Member

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update allso the readme files ?

@@ -1,98 +0,0 @@
import time
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have elasticsearch test w/o benchmark-runner.
Can we have the same test but using benchmark-runner uperf pod ?


# This path is GitHub actions runner path (benchmark-operator should be cloned here)
# This path is GitHub actions runner path
self._environment_variables_dict['runner_path'] = EnvironmentVariables.get_env('RUNNER_PATH', '/tmp')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should replace:
self._environment_variables_dict['pin_node_benchmark_operator'] = EnvironmentVariables.get_env('PIN_NODE_BENCHMARK_OPERATOR', '')
by:
self._environment_variables_dict['pin_node0'] = EnvironmentVariables.get_env('PIN_NODE0, '')

@arpsharm arpsharm force-pushed the remove-benchmark-operator-references branch from f080785 to 7584f53 Compare April 17, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants