[build] replace 'shelljs''s which with 'which' API#5195
Draft
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
Draft
[build] replace 'shelljs''s which with 'which' API#5195vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
...as no need to drag the whole shelljs dependency into the extension while we mostly need the only 'which' function of it. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5195 +/- ##
===========================================
+ Coverage 32.37% 44.62% +12.24%
===========================================
Files 85 100 +15
Lines 6505 8818 +2313
Branches 1349 1936 +587
===========================================
+ Hits 2106 3935 +1829
- Misses 4399 4883 +484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as no need to drag the whole shelljs dependency into the extension while we mostly need the only 'which' function of it.