[Draft] Migrate from istanbul to nyc #3025#4862
Draft
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
Draft
[Draft] Migrate from istanbul to nyc #3025#4862vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
vrubezhny wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
vrubezhny
force-pushed
the
fix-replace-istanbul-with-nyc
branch
4 times, most recently
from
6d02f30 to
3190798
Compare
Currently not working example of using `nyc`: changed for test coverage in `unit` tests: ``` npm run test:coverage ``` The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command) The `istanbul` dependecy is not removed yet due to not changed: - test/coverage.ts - test/ui/cluster-ui-test.ts - test/ui/public-ui-test.js depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report. Fixes: redhat-developer#3025 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-replace-istanbul-with-nyc
branch
from
3190798 to
a5f7ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently not working example of using
nyc: changed to nyc for coverage inunittests:The source instrumenting is done by
npm run test:instrument(invoked as part oftest:coveragecommand)The
istanbuldependecy is not removed yet due to not changed:istanbulAPI, which is subject to change afternycfinally provides a valuable coverage report.