#2906 Refactor activate()#4434
Open
MeherSru wants to merge 1 commit into
Open
Conversation
datho7561
requested changes
Jun 23, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Seems to working well, I think some of the formatting needs to be cleaned up
|
|
||
| try { | ||
| requirementsData = await requirements.resolveRequirements(context); | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
The indentation from here to the end of the method is at different levels; could you please reformat it to be consistent?
| cleanWorkspaceExists: boolean | ||
| ): Promise<void> { | ||
| if (requireSyntaxServer) { | ||
| const serverOptions = prepareExecutable(requirements, syntaxServerWorkspacePath, context, true); |
Contributor
There was a problem hiding this comment.
Same comment about reformatting but for this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.