Fix paste handling for single line copies #4306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Jan 13, 2026
src/pasteEventHandler.ts
Outdated
|
|
||
| // Skip paste handling for single line copies from the same document to avoid unwanted escaping | ||
| // in string literals when copying lines | ||
| const isSingleLineCopy = !insertText.includes('\n') && !insertText.includes('\r'); |
Collaborator
There was a problem hiding this comment.
change to
const editorData = dataTransfer.get("vscode-editor-data")?.value;
const isSingleLineCopy = Boolean(editorData && JSON.parse(editorData).isFromEmptySelection);
src/pasteEventHandler.ts
Outdated
Comment on lines
85
to
89
| // Skip paste handling when pasting content that contains quotes to avoid unwanted escaping | ||
| // This is a broader check than the above to handle cases where content is modified or from different documents | ||
| if (insertText.includes('"')) { | ||
| return undefined; // Let VS Code handle this normally | ||
| } |
Collaborator
There was a problem hiding this comment.
You need to remove this whole block, as it simply breaks the smart pasting feature
Contributor
Author
|
Thanks for the feedback, @fbricon. I have updated the logic and remove the redundant quote-checking block as suggested. |
Collaborator
|
thanks @CookedMelon |
fbricon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A description of this issue can be found at this link #4305