Skip to content

Add timeouts to license download to prevent hanging #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robstryker merged 1 commit into from
May 13, 2026
Merged

Add timeouts to license download to prevent hanging #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...sp.runtime.core/src/main/java/org/jboss/tools/rsp/runtime/core/model/DownloadRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.net.URL;
import java.net.URLConnection;
import java.util.HashMap;

import org.jboss.tools.rsp.api.dao.DownloadRuntimeDescription;
Expand Down Expand Up @@ -66,13 +67,16 @@ public String getLicense(IProgressMonitor monitor) throws CoreException {
try(ByteArrayOutputStream out = new ByteArrayOutputStream()) {
if (getLicenseURL() == null)
return null;

URL url = new URL(getLicenseURL());
InputStream in = url.openStream();
URLConnection conn = url.openConnection();
conn.setConnectTimeout(2500); // 2.5 second connection timeout
conn.setReadTimeout(5000); // 5 second read timeout
InputStream in = conn.getInputStream();
copyWithSize(in, out, monitor, 0);
return new String(out.toByteArray());
} catch (IOException e) {
throw new CoreException(new Status(IStatus.ERROR,
throw new CoreException(new Status(IStatus.ERROR,
RuntimeCoreActivator.PLUGIN_ID, 0,
NLS.bind(Messages.DownloadRuntime_Unable_to_fetch_license, e.getLocalizedMessage()), e));
}
Expand Down
Loading