Skip to content

Fixes #738 - Add JDK serial filter to WildFly launch arguments #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robstryker merged 1 commit into from
May 13, 2026
Merged

Fixes #738 - Add JDK serial filter to WildFly launch arguments #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...org/jboss/tools/rsp/server/wildfly/servertype/capabilities/WildFlyExtendedProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.jboss.tools.rsp.server.spi.servertype.IServer;
import org.jboss.tools.rsp.server.wildfly.servertype.launch.Wildfly100DefaultLaunchArguments;
import org.jboss.tools.rsp.server.wildfly.servertype.launch.Wildfly110DefaultLaunchArguments;
import org.jboss.tools.rsp.server.wildfly.servertype.launch.Wildfly340DefaultLaunchArguments;
import org.jboss.tools.rsp.server.wildfly.servertype.launch.Wildfly80DefaultLaunchArguments;

public class WildFlyExtendedProperties {
Expand Down Expand Up @@ -114,12 +115,12 @@ public Wildfly270ExtendedProperties(IServer server) {
}
public static class Wildfly350ExtendedProperties extends AbstractWildflyExtendedProperties {
public Wildfly350ExtendedProperties(IServer server) {
super("35.0", "17", "21.", HTTP_REMOTING_JMX_NEW, new Wildfly110DefaultLaunchArguments(server), server);
super("35.0", "17", "21.", HTTP_REMOTING_JMX_NEW, new Wildfly340DefaultLaunchArguments(server), server);
}
}
public static class Wildfly380ExtendedProperties extends AbstractWildflyExtendedProperties {
public Wildfly380ExtendedProperties(IServer server) {
super("38.0", "17", "25.", HTTP_REMOTING_JMX_NEW, new Wildfly110DefaultLaunchArguments(server), server);
super("38.0", "17", "25.", HTTP_REMOTING_JMX_NEW, new Wildfly340DefaultLaunchArguments(server), server);
}
}
// NEW_SERVER_ADAPTER
Expand Down
46 changes: 46 additions & 0 deletions ...rg/jboss/tools/rsp/server/wildfly/servertype/launch/Wildfly340DefaultLaunchArguments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/*******************************************************************************
* Copyright (c) 2007 - 2013 Red Hat, Inc.
* Distributed under license by Red Hat, Inc. All rights reserved.
* This program is made available under the terms of the
* Eclipse Public License v2.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v20.html
*
* Contributors:
* Red Hat, Inc. - initial API and implementation
******************************************************************************/
package org.jboss.tools.rsp.server.wildfly.servertype.launch;

import org.jboss.tools.rsp.server.spi.servertype.IServer;

public class Wildfly340DefaultLaunchArguments extends JBoss71DefaultLaunchArguments {
public Wildfly340DefaultLaunchArguments(IServer s) {
super(s);
}

@Override
protected String getMemoryArgs() {
return "-Xms64m -Xmx512m "; //$NON-NLS-1$
}

@Override
public String getStartDefaultVMArgs() {
return super.getStartDefaultVMArgs()
+ "-Dorg.jboss.logmanager.nocolor=true -Djboss.bind.address.management=localhost " //$NON-NLS-1$
+ getJdkSerialFilter();
}

@Override
protected String getJaxpProvider() {
return ""; //$NON-NLS-1$
}

/**
* Returns the JDK serial filter argument for protection against deserialization attacks.
*
* @return the serial filter argument
*/
protected String getJdkSerialFilter() {
return "-Djdk.serialFilter=\"maxbytes=10485760;maxdepth=128;maxarray=100000;maxrefs=300000\" "; //$NON-NLS-1$
}

}
Loading