Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions workspaces/scorecard/.changeset/gentle-papers-glow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-jira': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-github': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-dependabot': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-sonarqube': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-filecheck': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-openssf': patch
'@red-hat-developer-hub/backstage-plugin-scorecard-common': patch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] phantom changeset entry

The changeset lists @red-hat-developer-hub/backstage-plugin-scorecard-common: patch but no files in the scorecard-common package are modified in this PR. All exports in scorecard-common already have @public release tags. Removing the ae-missing-release-tag suppression will produce zero changes to the scorecard-common API report, making this changeset entry gratuitous and triggering a needless patch version bump with no actual code delta.

Suggested fix: Remove the @red-hat-developer-hub/backstage-plugin-scorecard-common: patch line from the changeset.

---

Add missing `@public` release tags to all scorecard backend module exports and common types, and re-enable `ae-missing-release-tag` api-extractor warning.
2 changes: 1 addition & 1 deletion workspaces/scorecard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"build:backend": "yarn workspace backend build",
"build:all": "backstage-cli repo build --all",
"build:api-reports": "yarn build:api-reports:only",
"build:api-reports:only": "backstage-repo-tools api-reports -o ae-wrong-input-file-type,ae-undocumented,ae-missing-release-tag --validate-release-tags",
"build:api-reports:only": "backstage-repo-tools api-reports -o ae-wrong-input-file-type,ae-undocumented --validate-release-tags",
"build-image": "yarn workspace backend build-image",
"build:knip-reports": "backstage-repo-tools knip-reports",
"clean": "backstage-cli repo clean",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardModuleDependabot as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { createDependabotMetricProviders } from './metricProviders/DependabotMetricProviderFactory';

/** @public */
export const scorecardModuleDependabot = createBackendModule({
pluginId: 'scorecard',
moduleId: 'dependabot',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardModuleFilecheck as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { createFilecheckMetricProvider } from './metricProviders/FilecheckMetricProviderFactory';

/** @public */
export const scorecardModuleFilecheck = createBackendModule({
pluginId: 'scorecard',
moduleId: 'filecheck',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardModuleGithub as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { GithubOpenPRsProvider } from './metricProviders/GithubOpenPRsProvider';

/** @public */
export const scorecardModuleGithub = createBackendModule({
pluginId: 'scorecard',
moduleId: 'github',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardModuleJira as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { JiraOpenIssuesProvider } from './metricProviders/JiraOpenIssuesProvider';

/** @public */
export const scorecardModuleJira = createBackendModule({
pluginId: 'scorecard',
moduleId: 'jira',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardOpenSFFModule as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { createBackendModule } from '@backstage/backend-plugin-api';
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { createOpenSSFMetricProvider } from './metricProviders/OpenSSFMetricProvider';

/** @public */
export const scorecardOpenSFFModule = createBackendModule({
pluginId: 'scorecard',
moduleId: 'openssf',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@
* @packageDocumentation
*/

/** @public */
export { scorecardModuleSonarqube as default } from './module';
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import { scorecardMetricsExtensionPoint } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { SonarQubeMetricProviderFactory } from './metricProviders/SonarQubeMetricProviderFactory';

/** @public */
export const scorecardModuleSonarqube = createBackendModule({
pluginId: 'scorecard',
moduleId: 'sonarqube',
Expand Down
Loading