-
Notifications
You must be signed in to change notification settings - Fork 115
fix(scorecard): remove redundant /alpha re-export of translations #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard': patch | ||
| --- | ||
|
|
||
| Removed redundant /alpha re-export of translations. Translations are available from the main entry point. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,15 +6,11 @@ | |
| "types": "src/index.ts", | ||
| "exports": { | ||
| ".": "./src/index.ts", | ||
| "./alpha": "./src/alpha.ts", | ||
| "./legacy": "./src/legacyExports.ts", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] breaking-change Removing the ./alpha export entry point removes a documented import path. The 3.0.0 CHANGELOG stated 'translations remain at ./alpha', creating a contract consumers could rely on. Any consumer using the /alpha import path will get a module-not-found error after upgrading. The symbols are still available from the main entry point, so this is a path removal rather than a functional API break. Suggested fix: Change the changeset from patch to minor at minimum. If external consumers may be using the /alpha path, use major instead. |
||
| "./package.json": "./package.json" | ||
| }, | ||
| "typesVersions": { | ||
| "*": { | ||
| "alpha": [ | ||
| "src/alpha.ts" | ||
| ], | ||
| "legacy": [ | ||
| "src/legacyExports.ts" | ||
| ], | ||
|
|
||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] semver-classification
The changeset classifies this as a patch change, but removing a public export path is not a bug fix. It should be at least minor since it removes a documented (though transitional) import path.
Suggested fix: Change the changeset from patch to minor, or major if the team believes external consumers actively use the /alpha path.