Skip to content

chore: ignore maintainLockFilesWeekly preset#2421

Open
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:RHIDP-12428
Open

chore: ignore maintainLockFilesWeekly preset#2421
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:RHIDP-12428

Conversation

@kim-tsao
Copy link
Member

@kim-tsao kim-tsao commented Mar 2, 2026

Hey, I just made a Pull Request!

This preset was added to the Renovate config:best-practices preset recently. We want to ignore it because refreshing the lock file (deleting/recreating) can cause breakage if newer dependencies are incompatible with the plugins

https://issues.redhat.com/browse/RHIDP-12428

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao requested review from a team as code owners March 2, 2026 17:44
@rhdh-qodo-merge
Copy link

Review Summary by Qodo

Ignore maintainLockFilesWeekly preset in Renovate config

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Ignore maintainLockFilesWeekly preset in Renovate configuration
• Prevents automatic lock file refreshes that may cause dependency incompatibility issues
Diagram
flowchart LR
  A["Renovate Config"] -- "Add to ignorePresets" --> B["maintainLockFilesWeekly ignored"]
  B -- "Prevents" --> C["Automatic lock file refresh"]
  C -- "Avoids" --> D["Dependency incompatibility breakage"]
Loading

Grey Divider

File Changes

1. .github/renovate.json ⚙️ Configuration changes +2/-1

Add maintainLockFilesWeekly to ignored presets

• Added :maintainLockFilesWeekly to the ignorePresets array
• Prevents automatic weekly lock file maintenance that could introduce incompatible dependencies
• Aligns with Renovate best-practices preset configuration

.github/renovate.json


Grey Divider

Qodo Logo

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Mar 2, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@kim-tsao
Copy link
Member Author

kim-tsao commented Mar 2, 2026

we can ignore the Renovate Validator. It's unrelated to this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant