chore(deps): Replace k8s deps that have version 0.0.0#1088
chore(deps): Replace k8s deps that have version 0.0.0#1088olivergondza wants to merge 2 commits intoredhat-developer:masterfrom
Conversation
|
/retest |
|
|
||
| // Avoid CVE-2022-28948 | ||
| gopkg.in/yaml.v3 => gopkg.in/yaml.v3 v3.0.1 | ||
|
|
There was a problem hiding this comment.
I wonder if we should use an exact copy of the same block that we use in upstream argocd-operator:
- https://github.com/argoproj-labs/argocd-operator/blob/dabb25d60d9438cdb937fd50f63ffe2184399798/go.mod#L201
(which itself we directly copy from the same block ingo.modin Argo CD)
Why? This makes it easy to keep argocd-operator/gitops operator replace blocks in sync (and both in sync with argocd, which both heavily depend on).
Anyways, +1 from me for this change, we had this replace block before @svghadi recently removed it, so can check with him first to see what his reasoning was. (But as above, my preference is just stay exactly in sync with upstream arogcd replace block for convenience)
There was a problem hiding this comment.
Sounds like a good idea. FTR, here I have pinned the versions that intellij was struggling with, I have not aligned it with any other project.
There was a problem hiding this comment.
@jgwest, Synced in the last commit in this PR. argocd-operator needed a tweak too argoproj-labs/argocd-operator#2101.
There was a problem hiding this comment.
My intention was to clean up the replace statements since we had many of them and were running into issues during upgrades. But if copying the replaces from upstream works fine, we can go with that approach.
olivergondza
force-pushed
the
fix-intellij-idea-integration
branch
4 times, most recently
from
d589cab to
5573063
Compare
|
@jgwest, ok to lift your request for changes? |
Intellij integration relies on project introspection by `go list -m all`. Resolving these modules is failing otherwise. Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondza
force-pushed
the
fix-intellij-idea-integration
branch
from
5573063 to
2b2bcb3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What type of PR is this?
What does this PR do / why we need it:
Intellij integration relies on project introspection by
go list -m all. Resolving these modules is failing otherwise:Have you updated the necessary documentation?
Which issue(s) this PR fixes:
None
Test acceptance criteria:
How to test changes / Special notes to the reviewer: