Skip to content

feat(mtv-warm-cutover): add warm migration cutover#19

Open
stevefulme1 wants to merge 2 commits into
redhat-cop:mainfrom
stevefulme1:feat/warm-migration-cutover
Open

feat(mtv-warm-cutover): add warm migration cutover#19
stevefulme1 wants to merge 2 commits into
redhat-cop:mainfrom
stevefulme1:feat/warm-migration-cutover

Conversation

@stevefulme1
Copy link
Copy Markdown
Contributor

@stevefulme1 stevefulme1 commented Apr 6, 2026

Summary

  • Adds new mtv_warm_cutover role and playbook to finish warm migrations by triggering the cutover phase
  • Patches the Forklift Migration resource's spec.cutover with a timestamp to initiate the final CBT sync, source VM shutdown, and target VM boot
  • Supports targeting migrations by name, label selector, or plan name
  • Optional wait-for-completion with configurable retries/delay
  • Verifies migration succeeded after cutover completes
  • Companion to MFG-214 (PR feat(mtv-migrate): add warm migration plan support #18) which creates the warm migration plan

Resolves

MFG-216 — Finish warm migration step

Usage

mtv_warm_cutover_request:
  # By plan name
  - namespace: openshift-mtv
    plan_name: vmware-host-20260407-0800

  # By specific migration names with scheduled cutover
  - namespace: openshift-mtv
    names:
      - vmware-host-20260407-abc12
    cutover: "2026-04-07T02:00:00Z"

  # By label selector - immediate cutover
  - namespace: openshift-mtv
    label_selectors:
      - migration-batch=wave-1

Test plan

  • Verify yamllint passes (confirmed)
  • Verify ansible-lint --offline passes production profile (confirmed — 0 failures)
  • Integration: trigger cutover on an active warm migration by name
  • Integration: trigger cutover by plan name
  • Integration: verify cutover with scheduled timestamp
  • Integration: verify wait-for-completion detects success/failure
  • Verify already-cutover migrations are rejected gracefully

🤖 Generated with Claude Code

@stevefulme1 @claude
feat(mtv-warm-cutover): add warm migration cutover role
06069f9 
Add a new role and playbook to trigger cutover on active warm
migrations. Patches the Migration resource with a cutover timestamp
to initiate the final CBT sync, source VM shutdown, and target VM
boot. Supports targeting by migration name, label selector, or
plan name, with optional wait-for-completion verification.

Resolves: MFG-216

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stevefulme1 stevefulme1 requested a review from sabre1041 as a code owner April 6, 2026 16:53
spyrexd
spyrexd requested changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@spyrexd spyrexd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is only on the code. I have not tested functionality.

Comment thread roles/mtv_warm_cutover/meta/main.yml Outdated
Comment thread roles/mtv_warm_cutover/tasks/_apply_cutover.yml Outdated
Comment thread roles/mtv_warm_cutover/tasks/_apply_cutover.yml
@stevefulme1 @claude
fix(mtv-warm-cutover): address review feedback from spyrexd
eb9803e 
- Update min_ansible_version to 2.16.0
- Skip migrations that already have a cutover timestamp instead of failing
- Add argument_specs.yml declaring all role inputs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spyrexd spyrexd spyrexd approved these changes

@sabre1041 sabre1041 Awaiting requested review from sabre1041 sabre1041 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevefulme1 @spyrexd