Fix tls socket can block while doing clean shutdown on a forced disconnect#999
Closed
arevetchi wants to merge 4 commits intoredboltz:masterfrom
Closed
Fix tls socket can block while doing clean shutdown on a forced disconnect#999arevetchi wants to merge 4 commits intoredboltz:masterfrom
arevetchi wants to merge 4 commits intoredboltz:masterfrom
Conversation
Owner
|
@arevetchi Thank you for sending the PR. |
Contributor
Author
|
@redboltz Thank you for prompt response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS socket can block on a
force_disconnectwhen network interface is down, or the other end is not responding, as it callsclean_shutdown_and_closewitch tries to shutdown tls socket gracefully.This is a stack trace from one scenario when network is set down, or simply the cable gets pulled out for testing purposes, when
pingreqtimer fires it tries to to a clean tls socket shutdown and it block indefinitely.