Skip to content

crux_http to use form of http-types#195

Merged
StuartHarris merged 1 commit intomasterfrom
http-types-fork
Feb 1, 2024
Merged

crux_http to use form of http-types#195
StuartHarris merged 1 commit intomasterfrom
http-types-fork

Conversation

@StuartHarris
Copy link
Copy Markdown
Member

The published http-types crate uses 128bit trace_id, which doesn't compile for wasm32-unknown-emscripten.

See http-rs/http-types#522

@StuartHarris StuartHarris requested a review from obmarg January 31, 2024 14:17
Copy link
Copy Markdown
Contributor

@obmarg obmarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔 etc (but yeah, what can we do)

@StuartHarris StuartHarris merged commit d851b47 into master Feb 1, 2024
@StuartHarris StuartHarris deleted the http-types-fork branch February 1, 2024 08:27
@charypar charypar restored the http-types-fork branch February 1, 2024 10:09
@charypar charypar deleted the http-types-fork branch February 1, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants