[Php56] Add missing parentheses for lower-precedence operands in PowToExpRector#8161
Merged
Merged
Conversation
…oExpRector pow() converted to ** dropped required parentheses around operands that bind looser than the ** operator, changing semantics. Wrap unary operators, casts, ternary, compound assignments, print and yield operands when needed. Fixes rectorphp/rector#9804
Precedence checks for ** operands are reusable by any rule that builds a Pow node from arbitrary operands, e.g. compound **= handling.
Member
Author
|
Let's ship this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9804
PowToExpRectorconvertspow($a, $b)to$a ** $b, but**binds tighter than most operators. When an operand binds looser, dropping the parentheses silently changes the result.Before
After
Operands already legal bare on the right-hand side of
**stay clean:Handled operand types: unary
~ ! + -, casts,instanceof, ternary, compound assignments (+=etc.),print,yield,yield from. Left and right operands are treated separately since unary/cast operands only need wrapping on the left.Verified by evaluating original vs. transformed code in real PHP: identical output for every case.