[AnnotationsToAttributes] Avoid partial apply on CoversAnnotationWithValueToAttributeRector#705
Merged
Conversation
…ValueToAttributeRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Can you add test fixture as well? |
Member
Author
|
not sure, as the issue happen on phpunit 10, and this repo already uses phpunit 12, so it always work ok on phpunit 12 as already all there. The example use is on spiral framework: |
Member
|
I see 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When apply partial migration, this rule may cause error:
this PR make early check that all possible migration class are there first so no more partial apply due to PHPUnit minor version introduce new attribute classes.