Skip to content

This PR fixes issue #1286 where mobile screens showed extra blank space #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iaadillatif wants to merge 1 commit into
base: main
Choose a base branch
from
Open

This PR fixes issue #1286 where mobile screens showed extra blank space #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FloatingContributors/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ The `FloatingContributors` component is a dynamic React component that displays

2. Use it in your application:
```tsx
<FloatingContributors headerEmbedded={false} />
<FloatingContributors heroEmbedded={false} />
```

---
Expand Down
20 changes: 10 additions & 10 deletions src/components/FloatingContributors/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@
}

interface FloatingContributorsProps {
headerEmbedded?: boolean;
heroEmbedded?: boolean;
}

const FloatingContributors: React.FC<FloatingContributorsProps> = ({
headerEmbedded = false,
heroEmbedded = false,
}) => {
const [contributors, setContributors] = useState<Contributor[]>([]);
const [activities, setActivities] = useState<ContributorActivity[]>([]);
Expand Down Expand Up @@ -440,7 +440,7 @@
};

// Get icon for action type
const getActionIcon = (action: ContributorActivity["action"]): string => {

Check warning on line 443 in src/components/FloatingContributors/index.tsx

View workflow job for this annotation

GitHub Actions / lint 

'getActionIcon' is assigned a value but never used
switch (action) {
case "pushed":
return "🚀";
Expand Down Expand Up @@ -491,11 +491,11 @@
<AnimatePresence>
{isVisible && (
<motion.div
className={`floating-contributors-container ${headerEmbedded ? "header-embedded" : ""}`}
className={`floating-contributors-container ${heroEmbedded ? "header-embedded" : ""}`}
initial={{
opacity: 0,
y: headerEmbedded ? 0 : 50,
scale: headerEmbedded ? 1 : 0.9,
y: heroEmbedded ? 0 : 50,
scale: heroEmbedded ? 1 : 0.9,
Comment on lines +494 to +498
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prop was renamed to heroEmbedded, but the conditional class name is still "header-embedded". This naming mismatch is confusing for future maintenance and makes it harder to grep/understand which styles apply to the hero vs other contexts. Consider renaming the CSS hook to hero-embedded (and updating the corresponding selectors in FloatingContributors.css), or keep the prop name aligned with the existing header-embedded styling.

Copilot uses AI. Check for mistakes.
}}
animate={{
opacity: 1,
Expand All @@ -504,26 +504,26 @@
}}
exit={{
opacity: 0,
y: headerEmbedded ? 0 : 50,
scale: headerEmbedded ? 1 : 0.9,
y: heroEmbedded ? 0 : 50,
scale: heroEmbedded ? 1 : 0.9,
}}
transition={{
duration: headerEmbedded ? 0.8 : 0.6,
duration: heroEmbedded ? 0.8 : 0.6,
ease: [0.4, 0, 0.2, 1],
}}
>
{/* Main floating card */}
<motion.div
className="floating-contributors-card"
animate={
headerEmbedded
heroEmbedded
? {}
: {
y: [0, -8, 0],
}
}
transition={
headerEmbedded
heroEmbedded
? {}
: {
duration: 4,
Expand Down
180 changes: 0 additions & 180 deletions src/components/header.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading