Re-add @-prefixed response files#6815
Open
dflems wants to merge 2 commits into
Open
Conversation
Author
|
@SimplyDanny - maybe you could comment on whether this was intentional in the original PR or more of an accidental casualty 😅 |
Generated by 🚫 Danger |
dflems
commented
Jul 16, 2026
|
|
||
| func run() async throws { | ||
| // Analyze files in current working directory if no paths were specified. | ||
| let allPaths = paths.isNotEmpty ? paths : [URL.cwd] |
Author
There was a problem hiding this comment.
Moved this to the resolvedPaths helper so it's shared between the lint and analyze commands
dflems
commented
Jul 16, 2026
| } ?? [arg] | ||
| } | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Same implementation that was formerly in Source/SwiftLintFramework/CompilerArgumentsExtractor.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once upon a time, SwiftLint supported
@-prefixed response/param files in thelintandanalyzesubcommands. Likexcfilelistfiles, these would be expanded in-place in the command. It seems this functionality was (perhaps accidentally) removed in #5811 (0.57.1) with the last (unused) vestiges of it removed in #6125.This PR adds it back. It repurposes a bit of code from
CompilerArgumentsExtractorand shares it across both use cases. Practically there's no major difference other than that@-prefixed arguments are expanded in-place.