Adds Variable Shadowing Rule

[nadeemnali]

Summary

Adds a new variable_shadowing rule that detects when a variable declaration shadows an identifier from an outer scope.

Changes

• New Rule: VariableShadowingRule.swift - flags variable declarations that shadow outer scope identifiers
• Registration: Added to BuiltInRules.swift
• Tests: Added generated tests in GeneratedTests_10.swift
• Configuration: Updated default_rule_configurations.yml
• Documentation: Updated CHANGELOG.md

Example

var outer: String = "hello"
func test() {
    let outer = "world"  // ❌ Violates rule
}

Relates to: #6228

[SwiftLintBot]

	802 Warnings
⚠️	This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:302:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:94:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:96:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:97:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:413:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:415:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:294:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:296:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Features/CachedResponseHandler.swift:87:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Features/NetworkReachabilityManager.swift:198:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Features/NetworkReachabilityManager.swift:207:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Features/RedirectHandler.swift:91:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:307:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:49:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:76:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:145:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Alamofire: /Tests/SessionTests.swift:168:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/App/iOS/Delegates/SceneDelegate.swift:751:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistMediaStreamer.swift:126:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistSharedFolder.swift:199:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/AccountActivityStore.swift:476:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/TransactionsActivityStore.swift:294:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift:514:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Transactions/TransactionParser.swift:1133:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Transactions/TransactionParser.swift:1160:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Blockies/Blockies.swift:75:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Shared/Functions.swift:20:7: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Favicon/BundledFaviconRenderer.swift:105:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Settings/Features/ShieldsPrivacy/FilterLists/FilterListsView.swift:243:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Settings/Debug/SandboxInspectorView.swift:92:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/PlaylistScriptHandler.swift:199:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Settings/SettingsViewController.swift:836:19: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Sandboxed/BraveTranslateScriptHandler.swift:254:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NavigationRouter.swift:58:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Playlist/Utilities/PlaylistThumbnailUtility.swift:258:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Playlist/ManagersAndCache/PlaylistCacheLoader.swift:341:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Menu.swift:269:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Menu.swift:270:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ReaderMode.swift:180:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ReaderMode.swift:181:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+TabPolicyDecider.swift:354:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ShareActivity.swift:230:23: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageFlowLayout.swift:91:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Sync/SyncSettingsTableViewController.swift:628:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/DeviceCheck/DeviceCheck.swift:366:19: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ContentBlocker/ContentBlockerManager.swift:362:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ContentBlocker/ContentBlockerManager.swift:395:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Reachability.swift:90:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Markdown/CodeHighlight/MarkdownParser.swift:75:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/WebUI/AIChatSettingsViewModel.swift:112:15: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/BlockedResource.swift:291:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Onboarding/ProductNotifications/NotificationBorderView.swift:19:11: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Brave: /ios/brave-ios/Sources/Onboarding/Callouts/OnboardingRewardsAgreementViewController.swift:355:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UITests/HTTPSUpgradeUITests.swift:89:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UITests/NavigationProtectionUITests.swift:350:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreSavingTests.swift:197:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreSavingTests.swift:235:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreSavingTests.swift:274:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreSavingTests.swift:312:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/History/Services/HistoryStoreTests.swift:118:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/History/Services/HistoryStoreTests.swift:119:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/History/Services/HistoryStoreTests.swift:194:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/Core/FileLoader.swift:37:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Favicons.swift:238:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Favicons.swift:437:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginPromptViewController.swift:137:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/LogViewer/LogViewerDataSource.swift:84:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/PerformanceTests/KeyValueFileStorePerformanceTests.swift:91:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/PerformanceTests/KeyValueFileStorePerformanceTests.swift:92:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/PerformanceTests/KeyValueFileStorePerformanceTests.swift:119:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/PerformanceTests/KeyValueFileStorePerformanceTests.swift:120:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGoTests/StringExtensionTests.swift:164:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGoTests/StringExtensionTests.swift:165:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/VPN/Tests/VPNTests/TestData.swift:45:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/AttributedMetric/Sources/AttributedMetricTestsUtils/TimeMachine.swift:30:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/UIComponents/Sources/UIComponents/macOS/CustomToggleControl.swift:414:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/IntegrationTests/Downloads/DownloadListCoordinatorTests.swift:449:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PrivacyConfigTests/JsonTestDataLoader.swift:39:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PixelKitTests/PixelKitTests.swift:539:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:508:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:431:9: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:443:13: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/BrowserServicesKitTests/Utils/JsonTestDataLoader.swift:39:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/BrowserServicesKitTests/GPC/GPCReferenceTests.swift:94:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/HistoryTests/HistoryStoreTests.swift:119:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/HistoryTests/HistoryStoreTests.swift:120:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/HistoryTests/HistoryStoreTests.swift:194:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/HistoryView/Sources/HistoryView/DataModel.swift:115:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/HistoryView/Sources/HistoryView/DataModel.swift:118:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/PasswordManager/PasswordManagerCoordinator.swift:247:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:129:37: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:143:37: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:157:37: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:171:37: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:186:33: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/PasswordManagementIdentityItemView.swift:251:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/SaveCredentialsViewController.swift:541:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/SecureVault/View/SaveCredentialsViewController.swift:548:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Tab/TabExtensions/DownloadsTabExtension.swift:122:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift:1551:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/AddressBarTextField.swift:894:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/DataImport/Logins/Firefox/FirefoxLoginReader.swift:101:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/FileManagerExtension.swift:99:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Model/BookmarkDragDropManager.swift:111:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Model/BookmarkDragDropManager.swift:184:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Bookmarks/Services/LocalBookmarkStore.swift:229:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/History/View/Dialogs/HistoryViewDeleteDialogModel.swift:141:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Menus/MainMenu.swift:1021:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Menus/MainMenu.swift:1022:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionIPCTunnelController.swift:156:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionIPCTunnelController.swift:197:29: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift:67:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Windows/View/WindowControllersManager.swift:342:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Windows/View/WindowControllersManager.swift:408:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ReferrerTrimming/ReferrerTrimming.swift:151:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift:696:25: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ContentBlocking/TrackerDataManager.swift:114:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ContentBlocking/ContentBlockerRulesSourceManager.swift:232:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/v1/APIRequest.swift:75:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/DistributedNavigationDelegate.swift:203:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/SpecialErrorPages/SpecialErrorData.swift:59:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/UITests/ReadingListTest.swift:103:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/ClientTests/TestHistory.swift:383:21: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/ClientTests/TestHistory.swift:396:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/ClientTests/Wallpaper/WallpaperNetworkingModuleTests.swift:82:18: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/StorageTests/TestSQLiteReadingList.swift:162:17: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/XCUITests/DatabaseFixtureTest.swift:65:16: Warning: Prefer not to shadow variables declared in outer scopes (variable_shadowing)
⚠️	Danger found 802 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 127.

	19 Messages
📖	Building this branch resulted in a binary size of 27431.12 KiB vs 27405.65 KiB when built on main (0% larger).
📖	Linting Aerial with this PR took 0.83 s vs 0.81 s on main (2% slower).
📖	Linting Alamofire with this PR took 1.07 s vs 1.05 s on main (1% slower).
📖	Linting Brave with this PR took 7.16 s vs 7.13 s on main (0% slower).
📖	Linting DuckDuckGo with this PR took 27.16 s vs 26.97 s on main (0% slower).
📖	Linting Firefox with this PR took 12.0 s vs 11.97 s on main (0% slower).
📖	Linting Kickstarter with this PR took 8.32 s vs 8.27 s on main (0% slower).
📖	Linting Moya with this PR took 0.48 s vs 0.45 s on main (6% slower).
📖	Linting NetNewsWire with this PR took 2.63 s vs 2.59 s on main (1% slower).
📖	Linting Nimble with this PR took 0.7 s vs 0.7 s on main (0% slower).
📖	Linting PocketCasts with this PR took 7.76 s vs 7.7 s on main (0% slower).
📖	Linting Quick with this PR took 0.47 s vs 0.44 s on main (6% slower).
📖	Linting Realm with this PR took 3.01 s vs 2.99 s on main (0% slower).
📖	Linting Sourcery with this PR took 1.9 s vs 1.81 s on main (4% slower).
📖	Linting Swift with this PR took 4.7 s vs 4.66 s on main (0% slower).
📖	Linting SwiftLintPerformanceTests with this PR took 0.35 s vs 0.35 s on main (0% slower).
📖	Linting VLC with this PR took 1.24 s vs 1.23 s on main (0% slower).
📖	Linting Wire with this PR took 18.67 s vs 18.64 s on main (0% slower).
📖	Linting WordPress with this PR took 12.72 s vs 12.6 s on main (0% slower).

Generated by 🚫 Danger