Skip to content

junit: add testsuite name and failure line metadata #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theamodhshetty wants to merge 2 commits into
base: main
Choose a base branch
from
Open

junit: add testsuite name and failure line metadata #6512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03112ef
Improve JUnit reporter metadata for CI parsers
theamodhshetty Feb 27, 2026
d111ba1
fix(junit): add root suite name and remove failure line attr
theamodhshetty Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
[ahmadalfy](https://github.com/ahmadalfy)
[#6499](https://github.com/realm/SwiftLint/issues/6499)

* Add `name="SwiftLint"` to JUnit `testsuites` and `testsuite` output for
better CI parser compatibility.
[theamodhshetty](https://github.com/theamodhshetty)
[#6161](https://github.com/realm/SwiftLint/issues/6161)

### Bug Fixes

* Ensure that disable commands work for `redundant_nil_coalescing` rule.
Expand Down
4 changes: 2 additions & 2 deletions Source/SwiftLintFramework/Reporters/JUnitReporter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ struct JUnitReporter: Reporter {

return """
<?xml version="1.0" encoding="utf-8"?>
<testsuites failures="\(warningCount)" errors="\(errorCount)" tests="\(testCount)">
\t<testsuite failures="\(warningCount)" errors="\(errorCount)" tests="\(testCount)">
<testsuites name="SwiftLint" failures="\(warningCount)" errors="\(errorCount)" tests="\(testCount)">
\t<testsuite name="SwiftLint" failures="\(warningCount)" errors="\(errorCount)" tests="\(testCount)">
\(violations.map(testCase(for:)).joined(separator: "\n"))
\t</testsuite>
</testsuites>
Expand Down
4 changes: 2 additions & 2 deletions Tests/FileSystemAccessTests/Resources/CannedJunitReporterOutput.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<testsuites failures="1" errors="3" tests="4">
<testsuite failures="1" errors="3" tests="4">
<testsuites name="SwiftLint" failures="1" errors="3" tests="4">
<testsuite name="SwiftLint" failures="1" errors="3" tests="4">
<testcase classname='Formatting Test' name='filename'>
<failure message='Violation Reason 1'>Warning:Line:1</failure>
</testcase>
Expand Down
Loading