Skip to content

Fix/pathway browser redirects#49

Open
el-rabies wants to merge 5 commits intomainfrom
fix/pathway-browser-redirects
Open

Fix/pathway browser redirects#49
el-rabies wants to merge 5 commits intomainfrom
fix/pathway-browser-redirects

Conversation

@el-rabies
Copy link
Copy Markdown
Collaborator

Change Summary:

  • Fixed double click on reacfoam cell
  • Resolved tool-tips position issue
  • Resolved issue where certain diagrams wouldn't display
  • Removed reaction diagram from details tab
  • Fixed breadcrumb home button redirect

@el-rabies el-rabies self-assigned this Mar 30, 2026
@el-rabies el-rabies linked an issue Mar 30, 2026 that may be closed by this pull request
5 tasks
@autofix-troubleshooter
Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@EliotRagueneau
Copy link
Copy Markdown
Contributor

  • Reaction diagrams are no longer part of the document ✅ , but still part of the TOC on the right, you probably want to change that
  • Some diagrams are still broken, seems like which ends is pointing (needs to have an arrow head) is incorrect:
  • Going back home (to reacfoam) from a diagram freezes the page (can be reproduced by clicking on the little home in the breadcrumbs while being in a diagram), didn't used to happen before the integration in the website, might be something related to the lazy loading of the dependency somehow. Is fixed with the following snippet in ReacfoamComponent, but shouldn't be necessary to use a setTimeout there when it used to work. Might need to work with Stanislaw to understand what's going on there, but seems rather hard to reproduce as a context. From what I could see, the issue is not the data being empty, nor the container not being the right one, but somehow in this new infrastructure, Foamtree needs a bit more delay between Object creation and data initialization, otherwise it get stuck in an endless loops
    effect(() => { // Initialise
      if (!(this.reacfoam.data() && this.foamTree())) return; // Set data whenever it is updated
      setTimeout(() => {
        this.foamTree().set('dataObject', {groups: this.reacfoam.data()!})
      })
      if (untracked(this.correctedSelectedId)) { // Initial select
        this.foamTree().select({groups: untracked(this.correctedSelectedId), keepPrevious: false}) // Preselect the group before relaxation happens to have the selection indicator during relaxation
      }
    });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make PathwayBrowser really work in that new context

3 participants