Skip to content

Conversation

@Shiva903-hue
Copy link

What does this PR do?

Preserves the default react-tabs className in UncontrolledTabs when
props.className is undefined or null.

Why?

Currently, spreading { ...defaultProps, ...props } causes an explicit
undefined or null className to override the default, which breaks
backward compatibility and styling.

Maintainers confirmed this behavior in #581.

What’s included

  • Guard against undefined / null overrides
  • Regression tests covering both cases

Related issue

Fixes #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

className default is lost when props.className is undefined in UncontrolledTabs

1 participant