feat(style): remove experimental_ prefix from backgroundSize, backgroundPosition and backgroundRepeat#57563
Open
intergalacticspacehighway wants to merge 7 commits into
Conversation
…ckgroundPosition` and `backgroundRepeat`
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
intergalacticspacehighway
marked this pull request as ready for review
July 15, 2026 13:16
…und-size-position-repeat # Conflicts: # packages/react-native/Libraries/StyleSheet/StyleSheetTypes.js # packages/react-native/ReactNativeApi.d.ts
intergalacticspacehighway
marked this pull request as draft
July 15, 2026 13:20
intergalacticspacehighway
marked this pull request as ready for review
July 15, 2026 13:22
facebook-github-tools
Bot
added
the
Shared with Meta
…und-size-position-repeat
intergalacticspacehighway
force-pushed
the
feat/graduate-background-size-position-repeat
branch
from
July 15, 2026 14:12
fa99d94 to
406620e
Compare
Graduating `backgroundSize`, `backgroundPosition` and `backgroundRepeat` by renaming them outright would break any app already using the `experimental_` prefixed names. Instead, keep the prefixed names working as aliases alongside the new ones, so the removal can happen in a later release. This mirrors what `backgroundImage` already does. The non-prefixed name takes precedence when both are set. - C++: nested `convertRawProp` fallback in the `BaseViewProps` constructor (this is also what registers the alias key with the raw props parser), plus an extra `RAW_SET_PROP_SWITCH_CASE` per prop in `setProp`. This is what covers iOS, which reads the typed props and never the raw names. - JS: alias entries in `ReactNativeStyleAttributes` (used wholesale as `style` by `BaseViewConfig.ios.js`) and in `BaseViewConfig.android.js`, plus the Flow and TypeScript style types. - Android additionally dispatches props to ViewManagers by string name, so each alias needs its own `ViewProps` constant and `@ReactProp` setter delegating to the real one.
…und-size-position-repeat Conflict was limited to the generated `ReactNativeApi.d.ts` (SignedSource and per-export content hashes). Resolved by regenerating with `yarn build-types` from the merged sources rather than hand-merging hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Promote
backgroundSize,backgroundPositionandbackgroundRepeatfrom theirexperimental_prefixed names to stable style props, followingbackgroundImagewhich was recently graduated in #57165.They have been available in experimental mode alongside
backgroundImagefor some time with no reported issues.Changelog:
[GENERAL][CHANGED] - Remove
experimental_prefix frombackgroundSize,backgroundPositionandbackgroundRepeatTest Plan:
Built and ran RNTester on Android and iOS. Migrated the Background Image example (size / position / repeat) to the graduated prop names.
cc - @jorge-cab