Skip to content

feat: introduce more granular event listeners#1040

Merged
vonovak merged 4 commits intomasterfrom
vonovak_feat_introduce_more_granular_event_listeners
Mar 17, 2026
Merged

feat: introduce more granular event listeners#1040
vonovak merged 4 commits intomasterfrom
vonovak_feat_introduce_more_granular_event_listeners

Conversation

@vonovak
Copy link
Member

@vonovak vonovak commented Mar 17, 2026

Summary

Introduces three dedicated event callbacks to replace the single onChange prop:

  • onValueChange(date: Date) — user selects a date/time
  • onDismiss() — picker dismissed without selection
  • onNeutralButtonPress() — neutral button pressed (Android only)

onChange is kept but deprecated. New listeners take precedence when provided; otherwise onChange fires as before.

Migration

 <DateTimePicker
   value={date}
-  onChange={(event, selectedDate) => {
-    if (event.type === 'dismissed') {
-      setShow(false);
-      return;
-    }
-    setDate(selectedDate);
-  }}
+  onValueChange={setDate}
+  onDismiss={() => setShow(false)}
 />

No breaking changes — fully backward compatible.

Test plan

  • green CI

@vonovak vonovak merged commit ad3f799 into master Mar 17, 2026
9 of 10 checks passed
@vonovak vonovak deleted the vonovak_feat_introduce_more_granular_event_listeners branch March 17, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant