Skip to content

Remove sourceURL(for:) override — superseded by bundleURL() in new architecture #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Remove sourceURL(for:) override — superseded by bundleURL() in new architecture #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions template/ios/HelloWorld/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,14 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
}

class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate {
#if !RCT_REMOVE_LEGACY_ARCH
// Required by `RCTBridgeDelegate` until the legacy architecture is fully
// removed. On newer React Native versions this symbol no longer exists, so
// the override is compiled out via SWIFT_ACTIVE_COMPILATION_CONDITIONS.
Comment on lines +38 to +40
Copy link
Copy Markdown
Member

@cortinico cortinico May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much verbose for being in the default template. The average users doesn't need to know about this at all

override func sourceURL(for bridge: RCTBridge) -> URL? {
self.bundleURL()
}
#endif

override func bundleURL() -> URL? {
#if DEBUG
Expand Down