Conversation
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 6, 2024
Summary: Since people mostly use Hermes, it doesn't make sense to download jsc-android from npm even when jsc is not used. This PR migrates the jsc-android to [mavenCentral](https://repo1.maven.org/maven2/io/github/react-native-community/jsc-android/2026004.0.0/). The new jsc-android supports Android 16KB memory page sizes and packaged by prefab. Relevant PRs: - react-native-community/jsc-android-buildscripts#184 - react-native-community/jsc-android-buildscripts#185 ## Changelog: [ANDROID] [CHANGED] - Migrate jsc-android to mavenCentral Pull Request resolved: #47972 Test Plan: CI passed Reviewed By: cipolleschi Differential Revision: D66772407 Pulled By: cortinico fbshipit-source-id: e34d2d138996e394763ef67d7aad65bb3e7b13dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
prepare the future support to publish artifact at maven central.
because people use hermes mostly and it doesn't make sense to download unnecessary jsc-android from npm
How
io.github.react-native-community:jsc-androidTest Plan
TODO
update README