-
-
Notifications
You must be signed in to change notification settings - Fork 240
feat: add a remove button element for semantic #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f41a045
feat: add 'close' semantic name and update TabNode styles and classNames
coding-ice ffc86fd
types: update TabNode styles and classNames to use Partial type for b…
coding-ice f0f7e8c
test: add unit test for editable Tabs component with custom className…
coding-ice 079a695
feat: enhance OperationNode to support custom classNames and styles f…
coding-ice e64d138
Update src/TabNavList/OperationNode.tsx
coding-ice 1b20c6f
test: add unit test for editable Tabs component to verify custom clas…
coding-ice 77c6040
refactor: rename 'close' to 'remove' in Tabs component for improved c…
coding-ice c4a0326
fix: correct import path for SemanticName in TabNode component
coding-ice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import { useEffect, useState } from 'react'; | |
| import type { EditableConfig, Tab, TabsLocale, MoreProps } from '../interface'; | ||
| import { getRemovable } from '../util'; | ||
| import AddButton from './AddButton'; | ||
| import { SemanticName } from '../Tabs'; | ||
|
|
||
| export interface OperationNodeProps { | ||
| prefixCls: string; | ||
|
|
@@ -27,6 +28,8 @@ export interface OperationNodeProps { | |
| getPopupContainer?: (node: HTMLElement) => HTMLElement; | ||
| popupClassName?: string; | ||
| popupStyle?: React.CSSProperties; | ||
| styles?: Pick<Partial<Record<SemanticName, React.CSSProperties>>, 'close'>; | ||
| classNames?: Pick<Partial<Record<SemanticName, string>>, 'close'>; | ||
| } | ||
|
|
||
| const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((props, ref) => { | ||
|
|
@@ -47,6 +50,8 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |
| getPopupContainer, | ||
| popupClassName, | ||
| popupStyle, | ||
| classNames, | ||
| styles, | ||
| } = props; | ||
| // ======================== Dropdown ======================== | ||
| const [open, setOpen] = useState(false); | ||
|
|
@@ -98,7 +103,8 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |
| type="button" | ||
| aria-label={removeAriaLabel || 'remove'} | ||
| tabIndex={0} | ||
| className={`${dropdownPrefix}-menu-item-remove`} | ||
| className={clsx(`${dropdownPrefix}-menu-item-remove`, classNames?.close)} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里的 close 语义,不太确定是不是要改为 |
||
| style={styles?.close} | ||
| onClick={e => { | ||
| e.stopPropagation(); | ||
| onRemoveTab(e, key); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.