Skip to content

fix: use only the attributes that are already defined #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codewizardTM wants to merge 2 commits into from
+3 −1
Closed

fix: use only the attributes that are already defined #1176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5214d06
fix: use only the attributes that are already defined
Nov 28, 2025
11ffabe
fix: filter attributes using pickAttrs
Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/SelectInput/Content/SingleContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,10 @@ const SingleContent = React.forwardRef<HTMLInputElement, SharedContentProps>(
if (displayValue && selectContext?.flattenOptions) {
const option = selectContext.flattenOptions.find((opt) => opt.value === displayValue.value);
if (option?.data) {
const { label, value, className, style, key, ...rest } = option.data;
const { className, style } = option.data;
Copy link
Copy Markdown
Contributor

@Wxh16144 Wxh16144 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是得考虑 fieldNames 配置？ 还是说这里的 label value 和 key 都是 merge 过的。另外看看能不能加一个测试用例。

Copy link
Copy Markdown
Author

@codewizardTM codewizardTM Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我重新修改了一下，这个 PR 我是想将不合法的属性不注入到 div 上，按我的理解和 fieldNames 的配置是不是没有关系


restProps = {
...restProps,
...rest,
title: getTitle(option.data),
className: clsx(restProps.className, className),
style: { ...restProps.style, ...style },
Expand Down
Loading