Skip to content

feat: Remove shortcut hints from locale#988

Open
Pareder wants to merge 1 commit into
react-component:masterfrom
Pareder:feat/remove-shortcut-hints
Open

feat: Remove shortcut hints from locale#988
Pareder wants to merge 1 commit into
react-component:masterfrom
Pareder:feat/remove-shortcut-hints

Conversation

@Pareder

@Pareder Pareder commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This PR is a small chunk of a big one #972 focusing on locales update.

These shortcut hints are redundant becuase screen reader should announce something like "Previous month button", it should not contain any hint.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@Pareder is attempting to deploy a commit to the afc163's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Pareder, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c09ec3a-ad3d-4ba2-9123-c99813236c21

📥 Commits

Reviewing files that changed from the base of the PR and between 6f6bbb3 and 31431e0.

⛔ Files ignored due to path filters (2)
  • tests/__snapshots__/panel.spec.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/range.spec.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (73)
  • src/locale/am_ET.ts
  • src/locale/ar_EG.ts
  • src/locale/az_AZ.ts
  • src/locale/bg_BG.ts
  • src/locale/bn_BD.ts
  • src/locale/by_BY.ts
  • src/locale/ca_ES.ts
  • src/locale/cs_CZ.ts
  • src/locale/da_DK.ts
  • src/locale/de_DE.ts
  • src/locale/el_GR.ts
  • src/locale/en_GB.ts
  • src/locale/en_US.ts
  • src/locale/es_ES.ts
  • src/locale/es_MX.ts
  • src/locale/et_EE.ts
  • src/locale/eu_ES.ts
  • src/locale/fa_IR.ts
  • src/locale/fi_FI.ts
  • src/locale/fr_BE.ts
  • src/locale/fr_CA.ts
  • src/locale/fr_FR.ts
  • src/locale/ga_IE.ts
  • src/locale/gl_ES.ts
  • src/locale/he_IL.ts
  • src/locale/hi_IN.ts
  • src/locale/hr_HR.ts
  • src/locale/hu_HU.ts
  • src/locale/id_ID.ts
  • src/locale/is_IS.ts
  • src/locale/it_IT.ts
  • src/locale/ja_JP.ts
  • src/locale/ka_GE.ts
  • src/locale/kk_KZ.ts
  • src/locale/km_KH.ts
  • src/locale/kmr_IQ.ts
  • src/locale/kn_IN.ts
  • src/locale/ko_KR.ts
  • src/locale/lt_LT.ts
  • src/locale/lv_LV.ts
  • src/locale/mk_MK.ts
  • src/locale/ml_IN.ts
  • src/locale/mn_MN.ts
  • src/locale/mr_IN.ts
  • src/locale/ms_MY.ts
  • src/locale/my_MM.ts
  • src/locale/nb_NO.ts
  • src/locale/ne_NP.ts
  • src/locale/nl_BE.ts
  • src/locale/nl_NL.ts
  • src/locale/pl_PL.ts
  • src/locale/pt_BR.ts
  • src/locale/pt_PT.ts
  • src/locale/ro_RO.ts
  • src/locale/ru_RU.ts
  • src/locale/si_LK.ts
  • src/locale/sk_SK.ts
  • src/locale/sl_SI.ts
  • src/locale/sr_Cyrl_RS.ts
  • src/locale/sr_RS.ts
  • src/locale/sv_SE.ts
  • src/locale/ta_IN.ts
  • src/locale/th_TH.ts
  • src/locale/tk_TK.ts
  • src/locale/tl_PH.ts
  • src/locale/tr_TR.ts
  • src/locale/ug_CN.ts
  • src/locale/uk_UA.ts
  • src/locale/ur_PK.ts
  • src/locale/uz_UZ.ts
  • src/locale/vi_VN.ts
  • src/locale/zh_CN.ts
  • src/locale/zh_TW.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes keyboard shortcut hints (such as PageUp, PageDown, and Control + arrow keys) from date picker navigation labels across numerous locale files, and updates the corresponding test snapshots. The review feedback identifies translation errors in the Catalan locale, where the translation for next year incorrectly refers to next month, and a typo in the Basque locale for the next year translation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/locale/ca_ES.ts
previousMonth: 'Mes anterior',
nextMonth: 'Mes següent',
previousYear: 'Any anterior',
nextYear: 'Mes següent',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Catalan, nextYear is incorrectly translated as 'Mes següent' (which means "Next month"). It should be 'Any següent' (Next year) to be correct and consistent with previousYear: 'Any anterior'.

Suggested change
nextYear: 'Mes següent',
nextYear: 'Any següent',

Comment thread src/locale/eu_ES.ts
previousMonth: 'Aurreko hilabetea',
nextMonth: 'Urrengo hilabetea',
previousYear: 'Aurreko urtea',
nextYear: 'Urrento urtea',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the Basque translation for nextYear. 'Urrento urtea' should be 'Urrengo urtea' to match the spelling of nextMonth: 'Urrengo hilabetea'.

Suggested change
nextYear: 'Urrento urtea',
nextYear: 'Urrengo urtea',

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (6f6bbb3) to head (31431e0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          66       66           
  Lines        2698     2698           
  Branches      749      724   -25     
=======================================
  Hits         2666     2666           
  Misses         29       29           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant