Avoid rc deep imports#434
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
概览该 PR 通过升级 变更导入路径迁移与 ESLint 配置
估计代码审查工作量🎯 2 (Simple) | ⏱️ ~10 分钟 可能相关的 PR
建议审查者
庆祝诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the @rc-component/util and @rc-component/father-plugin dependencies and refactors the codebase to use named imports from the root package instead of deep imports. Additionally, the ESLint configuration was updated to disable several TypeScript rules. Review feedback suggests merging imports from the same package in Collapse.tsx for conciseness and adding a defensive check in .eslintrc.js to prevent errors if base.overrides is undefined.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
调整内容
@rc-component/util/lib/*的引用调整为从@rc-component/util根入口导入。@rc-component/util到^1.11.1,升级@rc-component/father-plugin到^2.2.0。@typescript-eslint规则的关闭配置,避免升级后 lint 报 rule not found。背景
为了避免 rc 包之间依赖
es/lib构建产物内部路径,统一改为依赖公开根入口。后续深路径限制由@rc-component/father-plugin统一处理。验证
npm run lintSummary by CodeRabbit
发布说明
Chores
Refactor