rebase

[nhanasi]

• Create L2-tests.yml

• Update cov_build.sh

• Update remote_debugger.json

• Create uploadRRDL2Logs.sh

• Update uploadRRDL2Logs.sh

• Create run_l2.sh

• Create rrd_start_control.feature

• Create test_rrd_start_control.py

• Create rrd_single_instance.feature

• Create rrd_start_subscribe_and_wait.feature

• Create test_rrd_start_subscribe_and_wait.py

• Create test_rrd_single_instance.py

• Create helper_functions.py

• Update run_l2.sh

• Update L2-tests.yml

• Update run_l2.sh

• Delete scripts/uploadRRDL2Logs.sh

• Update rrd_start_control.feature

• RDK-56099: Pytest L2 Implementation Code Changes

Add L2 test cases for following scenarios

1. corrupted static profile
2. harmfull command in static profile
3. Missing issue in static profile
4. Empty issue rbus event
5. Static profile report
6. Static profile Category report

• Update remote_debugger.json

• Create systemd-run

• Update run_l2.sh

• Create rrd_background_cmd_static_profile_report.feature

• Create test_rrd_background_cmd_static_profile_report.py

• Update uploadRRDLogs.sh

• Update helper_functions.py

• Update run_l2.sh

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ AravindanNC
✅ Abhinavpv28
✅ Alan-Ryan
✅ nhanasi
✅ venkat0557
❌ naveenkumarhanasi
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Copilot]

Pull request overview

Copilot reviewed 98 out of 98 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The spelling "harmfull" should be "harmful" in the variable name HARMFULL_STRING. This typo is used consistently across multiple files but should be corrected for proper English spelling.

[Copilot]

The spelling "shopuld" should be "should" in this feature file scenario description.

[Copilot]

The spelling "commmand" has an extra 'm' and should be "command".

[Copilot]

Variable node is not used.

[Copilot]

Variable subnode is not used.

[Copilot]

Variable ISSUE_FOUND is not used.

[Copilot]

Variable ISSUE_FOUND is not used.

[Copilot]

Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

[Copilot]

Pull request overview

Copilot reviewed 98 out of 98 changed files in this pull request and generated 3 comments.

[Copilot]

The variable names SCRIPT_SUCCESS and SCRIPT_FAILURE are swapped - their associated log messages are reversed. SCRIPT_SUCCESS checks for "upload Failed" and SCRIPT_FAILURE checks for "upload Success".

[Copilot]

Memory leak: The function deletes rbuf in the default case but not in other cases. This inconsistency can lead to memory leaks in EVENT_MSG and EVENT_WEBCFG_MSG cases.

[Copilot]

The commented out remove_logfile() line at line 104 should either be uncommented or removed. Leaving commented code reduces code clarity.

[Copilot]

Pull request overview

Copilot reviewed 98 out of 98 changed files in this pull request and generated 14 comments.

Comments suppressed due to low confidence (1)

src/rrdCommandSanity.c:154

• checkcmd returned by cJSON_Print is heap-allocated but is never freed anymore, and the code increments the pointer (checkcmd++), making it impossible to free correctly later. Keep the original pointer for cJSON_free, operate on a separate pointer/temporary buffer when trimming quotes/spaces, and also handle the case where cJSON_Print returns NULL before calling strlen.

         checkcmd = cJSON_Print(subcmd); // Print each command from the sanity command array in Json
         int len = strlen(checkcmd);
         if (len >= 2 && checkcmd[0] == '"' && checkcmd[len - 1] == '"') 
         {
             checkcmd[len - 1] = '\0'; // Remove closing quote
             checkcmd++;               // Move pointer forward to skip opening quote
             len -= 2;            // Adjust length after removing quotes
         }
         // Trim trailing spaces
         int j = len - 1;
         while (j >= 0 && isspace(checkcmd[j])) {
         checkcmd[j] = '\0';
         j--;
         }
         RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Checking for \"%s\" string in Issue commands... \n",__FUNCTION__,__LINE__,checkcmd);
         sanitystr = strstr(issuecmd,checkcmd);
         if (sanitystr)
         {
             RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Found harmful commands: %s, Exiting!!! \n",__FUNCTION__,__LINE__,sanitystr);
             return 1;
         }

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

checkval is logged with %s immediately after cJSON_Print(check) (line 459) before the NULL check; passing NULL to %s is undefined behavior and can crash. Also, in the NULL case you overwrite jsoncfg with a new parsed tree without cleaning up the previous one, leaking memory. Check for NULL before logging, and avoid re-reading/overwriting jsoncfg here (or delete the old tree and clearly transfer ownership).

[Copilot]

After copying uploadSTBLogs.sh to /lib/rdk/uploadSTBLogs.sh, the script runs chmod -R 777 /lib/rdk/uploadRRDLogs.sh again (line 46) instead of chmod'ing the newly copied uploadSTBLogs script. This leaves /lib/rdk/uploadSTBLogs.sh potentially non-executable in the L2 container.

Suggested change

	chmod -R 777 /lib/rdk/uploadRRDLogs.sh
	chmod -R 777 /lib/rdk/uploadSTBLogs.sh

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

SCRIPT_SUCCESS and SCRIPT_FAILURE are assigned to the opposite log messages (Success variable contains "...upload Failed" and vice versa), so the test will report inverted results. Swap the message assignments (or swap the branches) so success/failure checks match the log text.

[Copilot]

The mock adds rbus_get with a 4-argument signature, but production code calls rbus_get(handle, name, &value) (3 arguments). This signature mismatch will prevent reliable mocking and can break compilation when the mock wrapper is used. Update the mock interface/wrapper to match the actual rbus_get prototype (typically rbus_get(rbusHandle_t, const char*, rbusValue_t*)) and adjust the function pointer declarations accordingly.

[Copilot]

rrd_upload_cleanup_source_dir builds a shell command with snprintf("rm -rf %s", dir_path) and executes it via system(). If dir_path is attacker-controlled or contains shell metacharacters, this becomes command injection. Replace this with a safe recursive delete implementation (e.g., nftw/unlinkat), and validate the directory is within an expected base path before deletion.

[Copilot]

Pull request overview

Copilot reviewed 94 out of 116 changed files in this pull request and generated 10 comments.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.