Update rrdEventProcess.c by Abhinavpv28 · Pull Request #197 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-05-13T11:31:24Z

No description provided.

Abhinavpv28 · 2026-05-13T11:32:40Z

@copilot please work on the comment added in the PR

github-actions · 2026-05-13T11:32:43Z

Code Coverage Summary

                               Total:|83.5%   5890|97.0%  1531|    -      0

Copilot

Pull request overview

This PR updates processIssueTypeInStaticProfile() in the remote debugger event processing flow by adding an inline comment near the fallback path that checks the installed package when an issue isn’t found in the static JSON profile.

Changes:

Added an inline note/TODO comment before calling processIssueTypeInInstalledPackage() when the issue is not present in the static profile.

    else
    {
        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d] Issue Data Not found in Static JSON File... \n", __FUNCTION__, __LINE__);
+		//before this i have to check length of pIssueNode->Node or pIssueNode->Node+pIssueNode->subNode is less than 34 if true only i have to proceed 


Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/ddda5e68-d84d-4a89-ab64-02935f00a57f Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-13T11:35:08Z

@copilot please work on the comment added in the PR

Addressed in commit efa4d22: removed the unclear inline note from src/rrdEventProcess.c as requested by the PR review comment. No UI changes were involved in this update.

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-13T11:45:12Z

b'## Copyright scan failure
Commit: 899b304
Report detail: https://gist.github.com/rdkcmf-jenkins/e04e078f7dae01113094a4e3ba839f2b'

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

github-actions · 2026-05-13T12:02:57Z

Code Coverage Summary

                               Total:|83.2%   5917|96.8%  1534|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

        if(profileName && strlen(profileName) > 0){
+			if (strlen(profileName) > 34 ){
+			    length =0;	
+			}
            length = prefixlen + strlen(profileName) + suffixlen + 1;
        }


    { // Static Profile JSON Parsing or Read Fail
        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Static Profile Parse/Read failed... %s\n", __FUNCTION__, __LINE__, RRD_JSON_FILE);
-        processIssueTypeInInstalledPackage(rbuf, pIssueNode);
+        if (isIssueNodeLengthValidForInstalledPackage(pIssueNode))
+        {
+            processIssueTypeInInstalledPackage(rbuf, pIssueNode);
+        }
+        else
+        {
+            logInstalledPackageFallbackSkip(pIssueNode);
+        }


+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Issue node length %zu must be less than %u for installed package fallback\n",
+                __FUNCTION__, __LINE__, issueLen, ISSUE_NODE_LENGTH_LIMIT);


+			if (strlen(profileName) > 34 ){
+			    length =0;	
+			}
            length = prefixlen + strlen(profileName) + suffixlen + 1;


rdkcmf-jenkins · 2026-05-13T12:16:59Z


        if(profileName && strlen(profileName) > 0){
+			if (strlen(profileName) > 34 ){
+			    length =0;	


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unused value

Assigning value "0" to "length" here, but that stored value is overwritten before it can be used.

Low Impact, CWE-563
UNUSED_VALUE

github-actions · 2026-05-13T12:31:34Z

Code Coverage Summary

                               Total:|83.2%   5917|96.8%  1534|    -      0

github-actions · 2026-05-13T12:32:51Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

        if(profileName && strlen(profileName) > 0){
+			if (strlen(profileName) > RRD_DYNAMIC_PROFILE_MAX_LENGTH ){
+			    return 0;
+			}
            length = prefixlen + strlen(profileName) + suffixlen + 1;


github-actions · 2026-05-13T12:35:48Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

github-actions · 2026-05-13T12:36:10Z

Code Coverage Summary

                               Total:|83.5%   5892|97.0%  1531|    -      0

Rebase

github-actions · 2026-05-14T05:20:32Z

Code Coverage Summary

                               Total:|84.1%   6226|97.3%  1660|    -      0

Update rrdEventProcess.c

00fce71

Copilot AI review requested due to automatic review settings May 13, 2026 11:31

Abhinavpv28 requested a review from a team as a code owner May 13, 2026 11:31

Copilot started reviewing on behalf of Abhinavpv28 May 13, 2026 11:32 View session

Copilot started work on behalf of Abhinavpv28 May 13, 2026 11:32 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

fix: remove unclear inline note from static profile fallback path

efa4d22

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/ddda5e68-d84d-4a89-ab64-02935f00a57f Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot finished work on behalf of Abhinavpv28 May 13, 2026 11:36

Copilot started work on behalf of Abhinavpv28 May 13, 2026 11:41 View session

chore: plan length-validation update for static fallback

899b304

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:43

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:43

fix: validate issue node length before installed-package fallback

6890ee6

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:45

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:45

chore: clarify installed-package length guard semantics

47b208f

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:46

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:46

chore: align length-limit wording with validation semantics

0b4e271

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:48

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:48

chore: improve fallback guard naming and failure logging

83d744f

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:49

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:49

refactor: centralize issue length and fallback skip logging

be9834c

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efaba2d2-7e7e-4927-bbe3-106dbb286e2b Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 11:50

Abhinavpv28 review requested due to automatic review settings May 13, 2026 11:50

Copilot finished work on behalf of Abhinavpv28 May 13, 2026 11:51

Update rrdDynamic.c

473c1b0

Copilot AI review requested due to automatic review settings May 13, 2026 12:01

Copilot started reviewing on behalf of Abhinavpv28 May 13, 2026 12:01 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

rdkcmf-jenkins reviewed May 13, 2026

View reviewed changes

Update rrdDynamic.c

f9548e1

Copilot AI review requested due to automatic review settings May 13, 2026 12:30

Copilot started reviewing on behalf of Abhinavpv28 May 13, 2026 12:30 View session

Update rrdEventProcess.c

b410def

Abhinavpv28 added 2 commits May 13, 2026 18:04

Update rrdCommon.h

b09a93c

Update rrdDynamic.c

b74040d

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread src/rrdDynamic.c

Comment on lines 137 to 141

if(profileName && strlen(profileName) > 0){

if (strlen(profileName) > RRD_DYNAMIC_PROFILE_MAX_LENGTH ){

return 0;

}

length = prefixlen + strlen(profileName) + suffixlen + 1;

Merge pull request #200 from rdkcentral/develop

2cf805b

Rebase

		RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Issue node length %zu must be less than %u for installed package fallback\n",
		__FUNCTION__, __LINE__, issueLen, ISSUE_NODE_LENGTH_LIMIT);

Conversation

Abhinavpv28 commented May 13, 2026

Uh oh!

Abhinavpv28 commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

rdkcmf-jenkins commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

rdkcmf-jenkins May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unused value

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rdkcmf-jenkins May 13, 2026 •

edited

Loading