Feature/rdk 60236 structure by Abhinavpv28 · Pull Request #192 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-05-04T15:05:34Z

No description provided.

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-05T16:49:05Z

@copilot /
[ RUN ] ProcessIssueTypeEvntTest.IssueTypeWithInvalidSuffixTreatedAsBase
Error!!! RDK Remote Debugger UT FAILED. EXIT!!!
...

Fixed in commit 17289c1. The segfault was caused by two NULL-pointer dereferences in the GTEST_ENABLE build path when rbuf->jsonPath is NULL:

processIssueTypeInStaticProfile: readAndParseJSON(rbuf->jsonPath) → fopen(NULL) → segfault. Added a NULL guard so jsonParsed stays NULL and the code falls through to processIssueTypeInInstalledPackage as it would for any parse failure.
processIssueTypeInInstalledPackage: strlen(rbuf->jsonPath) with NULL → segfault. Added an early-return guard when rbuf->jsonPath is NULL in GTEST mode.

All 328 tests now pass including ProcessIssueTypeEvntTest.IssueTypeWithInvalidSuffixTreatedAsBase.

Abhinavpv28 · 2026-05-06T01:40:03Z

@copilot
2026-05-06T01:34:03.3142692Z [ RUN ] IssueTypeSplitterTest.HandlesStringWithSpecialCharacters
2026-05-06T01:34:03.3143056Z rrdUnitTestRunner.cpp:1872: Failure
2026-05-06T01:34:03.3143310Z Expected equality of these values:
2026-05-06T01:34:03.3143525Z count
2026-05-06T01:34:03.3143680Z Which is: 5
2026-05-06T01:34:03.3143835Z 4
2026-05-06T01:34:03.3144133Z [ FAILED ] IssueTypeSplitterTest.HandlesStringWithSpecialCharacters (0 ms)

… built-in special-char removal) Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/00abcaba-8a41-4b88-ae12-07b5ff780ff9 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-06T01:55:33Z

@copilot
2026-05-06T01:34:03.3142692Z [ RUN ] IssueTypeSplitterTest.HandlesStringWithSpecialCharacters
2026-05-06T01:34:03.3143056Z rrdUnitTestRunner.cpp:1872: Failure
...

Fixed in commit 2d65f7e. The failure was caused by commit 31494a7 (which moved removeSpecialCharacterfromIssueTypeList() out of issueTypeSplitter() and into processIssueTypeEvent()). After that change, issueTypeSplitter() performs pure token splitting with no built-in special-char removal, so the test assertions were stale.

Updated HandlesStringWithSpecialCharacters to reflect the new contract:

Input "a@,b,&,cd,ef" now correctly returns 5 raw tokens ("a@", "b", "&", "cd", "ef") since issueTypeSplitter no longer filters characters internally.

All 328 tests pass.

github-actions · 2026-05-06T03:16:26Z

Code Coverage Summary

                               Total:|84.0%   6157|97.2%  1636|    -      0

Abhinavpv28 · 2026-05-06T03:16:46Z

@copilot i passed empty value, but it recieves random value

2026-05-06T03:12:25.585Z remotedebugger[3957]: [INFO ] [REMOTEDEBUGGER] [4029] [_remoteDebuggerEventHandler:423]: Received event for RRD_SET_ISSUE_EVENT Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RDKRemoteDebugger.IssueType
2026-05-06T03:12:25.586Z remotedebugger[3957]: [INFO ] [REMOTEDEBUGGER] [4029] [pushIssueTypesToMsgQueue:498]: SUCCESS: Message sending Done, ID=0 MSG= Size=1 Type=1 AppendMode=0!
2026-05-06T03:12:25.586Z remotedebugger[3957]: [INFO ] [REMOTEDEBUGGER] [4045] [getIssueInfo:288]: Received Main Node= LOG.RDK.REMOTEDEBUGGER, SubNode= (null)
2026-05-06T03:12:25.586Z remotedebugger[3957]: [INFO ] [REMOTEDEBUGGER] [4045] [processIssueTypeInStaticProfile:422]: Checking Static Profile...

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/4de31e24-70d8-496c-ac6a-a5376771d936 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot · 2026-05-06T03:26:23Z

...

Fixed in commit f64d401.

The root cause: when the IssueType value from RBUS is whitespace-only (e.g. a single space), _remoteDebuggerEventHandler passes it through (the dataMsg[0] == '\0' guard doesn't catch non-NUL whitespace). In processIssueTypeEvent, split_issue_type returns that whitespace as the base, and removeSpecialCharacterfromIssueTypeList then strips it to "" — but there was no post-strip empty check, so the empty base reached processIssueType and ultimately getIssueInfo with an empty mdata.

Two changes in processIssueTypeEvent:

Moved removeSpecialCharacterfromIssueTypeList(base) to run before dataMsgLen is calculated
Added a post-sanitization empty-base guard — if stripping leaves base empty, the token is skipped with an error log and we continue to the next token

New tests added: WhitespaceOnlyIssueTypeIsSkipped and EmptyStringIssueTypeIsSkipped.

Abhinavpv28 · 2026-05-06T06:01:58Z

@copilot
after our changes to add uuid suffix, the file is uploading, asper the logs. in the analytics portal i can see the file. but always hrowing download failed

github-actions · 2026-05-06T06:03:40Z

Code Coverage Summary

                               Total:|84.1%   6183|97.3%  1644|    -      0

…ectly rrd_logproc_convert_issue_type() was converting '-' to '_', turning the suffix '_Search-67768-67' into '_SEARCH_67768_67'. This added extra '_' separators into the archive filename that broke the analytics portal's filename parser — it could no longer identify the timestamp field, so download requests used an incorrect S3 key. Fix: keep '-' as '-' in the sanitized output. The archive filename now uses '_' to separate structural fields (MAC, issueType, timestamp) and '-' within the UUID suffix, giving the portal a reliable delimiter. Also increase issue_type_sanitized buffer in uploadRRDLogs.c from 64 to 256 bytes so a full UUID suffix never causes a silent truncation failure. Before: 04B86A12F9F8_DEVICE_DEVICEIP_SEARCH_67768_67_<timestamp>_RRD_DEBUG_LOGS.tgz After: 04B86A12F9F8_DEVICE_DEVICEIP_SEARCH-67768-67_<timestamp>_RRD_DEBUG_LOGS.tgz All 331 tests pass. Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/981b6bc1-c9d2-4150-9e9d-851004942ffc Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Abhinavpv28 added 30 commits April 30, 2026 23:22

Refactor issueTypeSplitter to include suffix handling

cd795e2

Update rrdEventProcess.c

a950f13

Update rrdExecuteScript.c

ba3c8ca

Refactor rrdEventProcess.h to rrdExecuteScript.h

63bc161

Update rrdExecuteScript.h

c883bd2

Update rrdExecuteScript.h

9380442

Update rrdEventProcess.h

61a9e2c

Update rrdExecuteScript.h

d672210

Update rrdJsonParser.c

65d30d0

Update rrdJsonParser.h

93df789

Update rrdInterface.c

6d37d71

Update rrdCommon.h

c7588d3

Update rrdEventProcess.c

d1345ab

Update rrdEventProcess.c

e720479

Update rrdEventProcess.c

faacd2a

Update rrdEventProcess.c

7daeac3

Fix indentation for appendMode assignment

52539a3

Update rrdCommon.h

ec1680e

Fix appendMode assignment in rrdEventProcess.c

bfb7f1e

Update rrdEventProcess.c

e71f82e

Update rrdJsonParser.c

72b9562

Update rrdEventProcess.c

e6b8690

Update rrdExecuteScript.h

79f6e64

Update rrdExecuteScript.c

bd49f43

Update rrdExecuteScript.c

3a5f988

Update rrdExecuteScript.c

4587984

Remove redundant logging from rrdJsonParser

5c3f460

Update rrdJsonParser.c

3d77c29

Update rrdEventProcess.c

b5f062b

Update rrdJsonParser.c

f21ad0f

Copilot AI and others added 2 commits May 5, 2026 16:45

Fix segfault in GTEST_ENABLE mode when rbuf->jsonPath is NULL

17289c1

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Remove accidentally committed dummy directory and update .gitignore

5c8ffb8

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/efdc0d6b-89e6-4423-b202-a900f5683839 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 5, 2026 16:45

Abhinavpv28 review requested due to automatic review settings May 5, 2026 16:45

Copilot finished work on behalf of Abhinavpv28 May 5, 2026 16:49

Copilot started work on behalf of Abhinavpv28 May 6, 2026 01:40 View session

Copilot AI review requested due to automatic review settings May 6, 2026 01:52

Abhinavpv28 review requested due to automatic review settings May 6, 2026 01:52

Copilot finished work on behalf of Abhinavpv28 May 6, 2026 01:55

Copilot started work on behalf of Abhinavpv28 May 6, 2026 03:16 View session

Fix empty/whitespace IssueType bypassing processIssueTypeEvent guards

f64d401

Agent-Logs-Url: https://github.com/rdkcentral/remote_debugger/sessions/4de31e24-70d8-496c-ac6a-a5376771d936 Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 6, 2026 03:26

Abhinavpv28 review requested due to automatic review settings May 6, 2026 03:26

Copilot finished work on behalf of Abhinavpv28 May 6, 2026 03:27

Copilot started work on behalf of Abhinavpv28 May 6, 2026 06:02 View session

Copilot stopped work on behalf of Abhinavpv28 due to an error May 6, 2026 06:11
The session was cancelled by the user.

Copilot started work on behalf of Abhinavpv28 May 6, 2026 06:15 View session

Copilot AI review requested due to automatic review settings May 6, 2026 06:20

Abhinavpv28 review requested due to automatic review settings May 6, 2026 06:20

Copilot finished work on behalf of Abhinavpv28 May 6, 2026 06:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/rdk 60236 structure#192

Feature/rdk 60236 structure#192
Abhinavpv28 wants to merge 89 commits intodevelopfrom
feature/RDK-60236_structure

Abhinavpv28 commented May 4, 2026

Uh oh!

Copilot AI commented May 5, 2026

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Abhinavpv28 commented May 4, 2026

Uh oh!

Copilot AI commented May 5, 2026

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Code Coverage Summary

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

Copilot AI commented May 6, 2026

Uh oh!

Abhinavpv28 commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Code Coverage Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants