Add holdInterval in keySimulator#211
Open
mshameersm wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the remote-control abstraction to support a holdInterval parameter (intended to represent holding a keypress) and updates the KeySimulator-backed remote controller to pass repeat/delay/hold options through to the underlying keySimulator command.
Changes:
- Added
holdIntervalparameter tocommonRemoteClass.sendKey()and propagated it to the selected remote controller. - Updated
remoteKeySimulator.sendKey()to invokekeySimulatoronce with-i(delay),-r(repeat), and-p(holdInterval) arguments. - Updated
remoteNone.sendKey()signature/logging to includeholdInterval.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| framework/core/remoteControllerModules/none.py | Adds holdInterval to the no-op remote controller interface/logging. |
| framework/core/remoteControllerModules/keySimulator.py | Passes repeat/delay/holdInterval via keySimulator CLI args instead of looping locally. |
| framework/core/commonRemote.py | Adds holdInterval to the public sendKey() API and forwards it to the active remote controller. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| code (str): keycode | ||
| repeat (int): number of repeats required | ||
| delay (int): delay in seconds between repeats | ||
| holdInterval (int): How long to wait between key presses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add holdInterval parameter for holding the keypress in KeySimulator.
Also, use the keySimulator arguments for delay & repeat as well.