DELIA-70047 by kiruba115 · Pull Request #187 · rdkcentral/control

kiruba115 · 2026-03-28T23:38:04Z

DELIA-70047

NSM to be fetched as a boolean instead of JSON object

Copilot

Pull request overview

Updates ControlMgr’s Thunder PowerManager integration to treat getNetworkStandbyMode as a boolean RPC result (instead of parsing a JSON object), adding a dedicated boolean-call helper to the Thunder plugin base.

Changes:

Add call_plugin_boolean() helper to invoke Thunder JSONRPC methods returning a boolean.
Update PowerManager NSM fetch to use the boolean helper.
Add an extra NSM log line in the main power-state-change handling.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
`src/thunder/ctrlm_thunder_plugin_powermanager.cpp`	Switch NSM retrieval to boolean helper and adjust logging.
`src/thunder/ctrlm_thunder_plugin.h`	Declare new `call_plugin_boolean()` helper.
`src/thunder/ctrlm_thunder_plugin.cpp`	Implement `call_plugin_boolean()` using `Core::JSON::Boolean`.
`src/ctrlm_main.cpp`	Add additional NSM logging during power state changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-28T23:40:14Z

src/thunder/ctrlm_thunder_plugin.h

@@ -124,6 +124,8 @@ class ctrlm_thunder_plugin_t {
     */
    bool call_plugin(std::string method, void *params, void *response, unsigned int retries = 0);



call_plugin_boolean is added without any header documentation, while the surrounding helper methods have Doxygen-style comments describing params/return values. Please add a matching comment block (and if you add a retries parameter for timeout handling, document that as well) to keep the header self-describing.

Suggested change

/**

* This function is used to call a Thunder Plugin method that returns a boolean result.

* @param method The method in which the user wants to call.

* @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)

* @param response Pointer to a boolean that will contain the result from the call.

* @return True if the call succeeded, otherwise False.

*/

Copilot · 2026-03-28T23:40:14Z

src/ctrlm_main.cpp

               XLOGD_INFO("NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");
            }
+            XLOGD_ERROR("DELIA-70047 NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");


This looks like a temporary ticket-specific debug log and it uses XLOGD_ERROR unconditionally. It also duplicates the earlier NSM log (and calls ctrlm_main_get_networked_standby_mode again), which can add noise. Please remove this line or downgrade it to DEBUG and gate it the same way as the existing NSM log.

Suggested change

XLOGD_INFO("NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");

}

XLOGD_ERROR("DELIA-70047 NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");

bool nsm_enabled = ctrlm_main_get_networked_standby_mode();

XLOGD_INFO("NSM is <%s>", nsm_enabled ? "ENABLED" : "DISABLED");

XLOGD_DEBUG("DELIA-70047 NSM is <%s>", nsm_enabled ? "ENABLED" : "DISABLED");

}

Copilot · 2026-03-28T23:40:15Z

src/thunder/ctrlm_thunder_plugin_powermanager.cpp

-      XLOGD_DEBUG("networked_standby_mode is %s", networked_standby_mode?"TRUE":"FALSE");
+   sem_wait(&this->semaphore);
+   if(this->call_plugin_boolean("getNetworkStandbyMode", (void *)&params, &networked_standby_mode)) {
+      XLOGD_ERROR("networked_standby_mode is %s", networked_standby_mode ? "TRUE" : "FALSE");


The success path logs the NSM value with XLOGD_ERROR, which will mark normal behavior as an error and can create noisy/alerting logs. This file uses DEBUG for successful state/value logs (e.g., power state and wakeup reason) and ERROR for failures; consider changing this to XLOGD_DEBUG/INFO and reserving XLOGD_ERROR for the failure branch.

Suggested change

XLOGD_ERROR("networked_standby_mode is %s", networked_standby_mode ? "TRUE" : "FALSE");

XLOGD_DEBUG("networked_standby_mode is %s", networked_standby_mode ? "TRUE" : "FALSE");

Copilot · 2026-03-28T23:40:15Z

src/thunder/ctrlm_thunder_plugin.cpp

+            if(thunderRet == Core::ERROR_NONE) {
+                *response = jsonResponse.Value();
+                ret = true;
+                XLOGD_ERROR("%s: Thunder call success <%s> <%u> response:%d \n", __FUNCTION__, method.c_str(), thunderRet, *response);


call_plugin_boolean logs a successful Thunder invoke using XLOGD_ERROR. This will incorrectly surface normal calls as errors; consider removing the success log entirely (to match call_plugin) or logging it at DEBUG/INFO instead.

Suggested change

XLOGD_ERROR("%s: Thunder call success <%s> <%u> response:%d \n", __FUNCTION__, method.c_str(), thunderRet, *response);

Copilot · 2026-03-28T23:40:15Z

src/thunder/ctrlm_thunder_plugin.cpp

+            uint32_t thunderRet = clientObject->Invoke<JsonObject, Core::JSON::Boolean>(CALL_TIMEOUT, _T(method), *jsonParams, jsonResponse);
+            if(thunderRet == Core::ERROR_NONE) {
+                *response = jsonResponse.Value();
+                ret = true;
+                XLOGD_ERROR("%s: Thunder call success <%s> <%u> response:%d \n", __FUNCTION__, method.c_str(), thunderRet, *response);
+            } else {
+                XLOGD_ERROR("%s: Thunder call failed <%s> <%u>\n", __FUNCTION__, method.c_str(), thunderRet);


This introduces a new Thunder call helper but it doesn’t support retries on Core::ERROR_TIMEDOUT like call_plugin/property_get do. To keep behavior consistent and avoid transient timeouts becoming hard failures, consider adding a retries parameter (default 0) and wrapping Invoke in the same timed-out retry loop used by call_plugin.

Suggested change

uint32_t thunderRet = clientObject->Invoke<JsonObject, Core::JSON::Boolean>(CALL_TIMEOUT, _T(method), *jsonParams, jsonResponse);

if(thunderRet == Core::ERROR_NONE) {

*response = jsonResponse.Value();

ret = true;

XLOGD_ERROR("%s: Thunder call success <%s> <%u> response:%d \n", __FUNCTION__, method.c_str(), thunderRet, *response);

} else {

XLOGD_ERROR("%s: Thunder call failed <%s> <%u>\n", __FUNCTION__, method.c_str(), thunderRet);

unsigned int attempts = 0;

unsigned int retries = 0; // keep current behavior: no retries beyond the initial attempt

uint32_t thunderRet = Core::ERROR_TIMEDOUT;

while(thunderRet == Core::ERROR_TIMEDOUT && attempts <= retries) { // Only retry on TIMEDOUT

thunderRet = clientObject->Invoke<JsonObject, Core::JSON::Boolean>(CALL_TIMEOUT, _T(method), *jsonParams, jsonResponse);

if(thunderRet == Core::ERROR_NONE) {

*response = jsonResponse.Value();

ret = true;

XLOGD_ERROR("%s: Thunder call success <%s> <%u> response:%d \n", __FUNCTION__, method.c_str(), thunderRet, *response);

} else {

attempts += 1;

XLOGD_ERROR("%s: Thunder call failed <%s> <%u>, attempt %u of %u\n",

__FUNCTION__,

method.c_str(),

thunderRet,

attempts,

(thunderRet == Core::ERROR_TIMEDOUT ? retries : 0) + 1); // retries + initial attempt

}

Kirubagaran Jayaraman and others added 3 commits March 28, 2026 02:04

Debug DELIA-70047

5382728

Update ctrlm_main.cpp

e286909

Update ctrlm_thunder_plugin.cpp

56fbc59

Copilot AI review requested due to automatic review settings March 28, 2026 23:38

Copilot started reviewing on behalf of kiruba115 March 28, 2026 23:38 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DELIA-70047#187

DELIA-70047#187
kiruba115 wants to merge 3 commits intodevelopfrom
DELIA-70047

kiruba115 commented Mar 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -124,6 +124,8 @@ class ctrlm_thunder_plugin_t {
		*/
		bool call_plugin(std::string method, void params, void response, unsigned int retries = 0);

+    /**
+     * This function is used to call a Thunder Plugin method that returns a boolean result.
+     * @param method The method in which the user wants to call.
+     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
+     * @param response Pointer to a boolean that will contain the result from the call.
+     * @return True if the call succeeded, otherwise False.
+     */

-               XLOGD_INFO("NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");
-            }
-            XLOGD_ERROR("DELIA-70047 NSM is <%s>", (ctrlm_main_get_networked_standby_mode())?"ENABLED":"DISABLED");
+               bool nsm_enabled = ctrlm_main_get_networked_standby_mode();
+               XLOGD_INFO("NSM is <%s>", nsm_enabled ? "ENABLED" : "DISABLED");
+               XLOGD_DEBUG("DELIA-70047 NSM is <%s>", nsm_enabled ? "ENABLED" : "DISABLED");
+            }

	XLOGD_ERROR("networked_standby_mode is %s", networked_standby_mode ? "TRUE" : "FALSE");
	XLOGD_DEBUG("networked_standby_mode is %s", networked_standby_mode ? "TRUE" : "FALSE");

Conversation

kiruba115 commented Mar 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants