Skip to content

Revert "VPLAY-13012: Strict adherence to manifest refresh interval for LLD"#1225

Open
pstroffolino wants to merge 1 commit intodev_sprint_25_2from
revert-1201-feature/VPLAY-13012_final
Open

Revert "VPLAY-13012: Strict adherence to manifest refresh interval for LLD"#1225
pstroffolino wants to merge 1 commit intodev_sprint_25_2from
revert-1201-feature/VPLAY-13012_final

Conversation

@pstroffolino
Copy link
Copy Markdown
Contributor

Reverts #1201

To isolate reason for l2 test regression

Copilot AI review requested due to automatic review settings March 23, 2026 18:53
@pstroffolino pstroffolino requested a review from a team as a code owner March 23, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts #1201 (“Strict adherence to manifest refresh interval for LLD”) to help isolate an L2 test regression related to LL-DASH MPD refresh behavior.

Changes:

  • Revert MPD refresh waiting logic to use the stored mRefreshInterval directly (removing elapsed-time compensation).
  • Revert waitForRefreshInterval API back to a no-argument method and update call sites accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
AampMPDDownloader.h Reverts waitForRefreshInterval signature back to no-arg.
AampMPDDownloader.cpp Reverts refresh-interval handling and related logging; adjusts publishTime-to-ms conversion.

Comment thread AampMPDDownloader.cpp
if(!publishTimeStr.empty())
{
publishTimeMSec = static_cast<uint64_t>(ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000.0);
publishTimeMSec = (uint64_t)ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000;
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publishTimeMSec conversion now casts the double seconds to uint64_t before multiplying by 1000, which truncates any fractional seconds (milliseconds) and can cause incorrect publish time comparisons (e.g., treating two different publishTime values within the same second as identical). Cast after multiplying (or keep the multiplication in double) and prefer static_cast<uint64_t> over a C-style cast to preserve precision and type safety.

Suggested change
publishTimeMSec = (uint64_t)ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000;
publishTimeMSec = static_cast<uint64_t>(
ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000.0
);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants