Revert "VPLAY-13012: Strict adherence to manifest refresh interval for LLD"#1225
Revert "VPLAY-13012: Strict adherence to manifest refresh interval for LLD"#1225pstroffolino wants to merge 1 commit intodev_sprint_25_2from
Conversation
…r LLD (#…" This reverts commit 3e13a74.
There was a problem hiding this comment.
Pull request overview
This PR reverts #1201 (“Strict adherence to manifest refresh interval for LLD”) to help isolate an L2 test regression related to LL-DASH MPD refresh behavior.
Changes:
- Revert MPD refresh waiting logic to use the stored
mRefreshIntervaldirectly (removing elapsed-time compensation). - Revert
waitForRefreshIntervalAPI back to a no-argument method and update call sites accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AampMPDDownloader.h | Reverts waitForRefreshInterval signature back to no-arg. |
| AampMPDDownloader.cpp | Reverts refresh-interval handling and related logging; adjusts publishTime-to-ms conversion. |
| if(!publishTimeStr.empty()) | ||
| { | ||
| publishTimeMSec = static_cast<uint64_t>(ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000.0); | ||
| publishTimeMSec = (uint64_t)ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000; |
There was a problem hiding this comment.
publishTimeMSec conversion now casts the double seconds to uint64_t before multiplying by 1000, which truncates any fractional seconds (milliseconds) and can cause incorrect publish time comparisons (e.g., treating two different publishTime values within the same second as identical). Cast after multiplying (or keep the multiplication in double) and prefer static_cast<uint64_t> over a C-style cast to preserve precision and type safety.
| publishTimeMSec = (uint64_t)ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000; | |
| publishTimeMSec = static_cast<uint64_t>( | |
| ISO8601DateTimeToUTCSeconds(publishTimeStr.c_str()) * 1000.0 | |
| ); |
Reverts #1201
To isolate reason for l2 test regression