Revert "VPLAY-12576 more consistent HttpRequestEnd formatting"#1222
Revert "VPLAY-12576 more consistent HttpRequestEnd formatting"#1222pstroffolino wants to merge 1 commit intodev_sprint_25_2from
Conversation
This reverts commit 160cc4a.
There was a problem hiding this comment.
Pull request overview
This PR reverts the logging-format changes from #1174 to help confirm the root cause of regressed L2 tests by restoring the prior HttpRequestEnd formatting behavior.
Changes:
- Reverts
HttpRequestEndlog float formatting (e.g.,%.3f↔%2.4f) in multiple components. - Reverts
timeoutClassstring construction for connection/timeout marker output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
priv_aamp.cpp |
Reverts HttpRequestEnd and CurlTrace log formatting and timeoutClass construction. |
drm/AampDRMLicManager.cpp |
Reverts DRM HttpRequestEnd log formatting and timeoutClass construction. |
AampMPDDownloader.cpp |
Reverts manifest download HttpRequestEnd float formatting. |
| // introduce extra marker for connection status curl 7/18/28, | ||
| // example 18(0) if connection failure with PARTIAL_FILE code | ||
| timeoutClass = "(" + std::to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")"; | ||
| timeoutClass = "(" + to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")"; |
There was a problem hiding this comment.
to_string(...) is unqualified here; without std::to_string (or a using declaration), this should not compile. Please change this back to std::to_string(...) (or add an explicit using std::to_string; in this source file).
| timeoutClass = "(" + to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")"; | |
| timeoutClass = "(" + std::to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")"; |
| // introduce extra marker for connection status curl 7/18/28, | ||
| // example 18(0) if connection failure with PARTIAL_FILE code | ||
| timeoutClass = "(" + std::to_string(reqSize > 0) + ")"; | ||
| timeoutClass = "(" + to_string(reqSize > 0) + ")"; |
There was a problem hiding this comment.
to_string(...) is used without the std:: qualifier (and there is no using namespace std; / using std::to_string; visible for this translation unit). This will fail to compile. Use std::to_string(...) here (or introduce a local using std::to_string; if that’s the preferred style).
Reverts #1174
Quick test to confirm RCA for regressed L2 tests