Skip to content

Revert "VPLAY-12576 more consistent HttpRequestEnd formatting"#1222

Open
pstroffolino wants to merge 1 commit intodev_sprint_25_2from
revert-1174-feature/VPLAY-12576-simplified
Open

Revert "VPLAY-12576 more consistent HttpRequestEnd formatting"#1222
pstroffolino wants to merge 1 commit intodev_sprint_25_2from
revert-1174-feature/VPLAY-12576-simplified

Conversation

@pstroffolino
Copy link
Copy Markdown
Contributor

Reverts #1174

Quick test to confirm RCA for regressed L2 tests

@pstroffolino pstroffolino requested a review from a team as a code owner March 23, 2026 18:20
Copilot AI review requested due to automatic review settings March 23, 2026 18:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the logging-format changes from #1174 to help confirm the root cause of regressed L2 tests by restoring the prior HttpRequestEnd formatting behavior.

Changes:

  • Reverts HttpRequestEnd log float formatting (e.g., %.3f%2.4f) in multiple components.
  • Reverts timeoutClass string construction for connection/timeout marker output.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
priv_aamp.cpp Reverts HttpRequestEnd and CurlTrace log formatting and timeoutClass construction.
drm/AampDRMLicManager.cpp Reverts DRM HttpRequestEnd log formatting and timeoutClass construction.
AampMPDDownloader.cpp Reverts manifest download HttpRequestEnd float formatting.

Comment thread drm/AampDRMLicManager.cpp
// introduce extra marker for connection status curl 7/18/28,
// example 18(0) if connection failure with PARTIAL_FILE code
timeoutClass = "(" + std::to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")";
timeoutClass = "(" + to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")";
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_string(...) is unqualified here; without std::to_string (or a using declaration), this should not compile. Please change this back to std::to_string(...) (or add an explicit using std::to_string; in this source file).

Suggested change
timeoutClass = "(" + to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")";
timeoutClass = "(" + std::to_string(respData->downloadCompleteMetrics.reqSize > 0) + ")";

Copilot uses AI. Check for mistakes.
Comment thread priv_aamp.cpp
// introduce extra marker for connection status curl 7/18/28,
// example 18(0) if connection failure with PARTIAL_FILE code
timeoutClass = "(" + std::to_string(reqSize > 0) + ")";
timeoutClass = "(" + to_string(reqSize > 0) + ")";
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_string(...) is used without the std:: qualifier (and there is no using namespace std; / using std::to_string; visible for this translation unit). This will fail to compile. Use std::to_string(...) here (or introduce a local using std::to_string; if that’s the preferred style).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants