RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#14
Merged
RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#14
Conversation
There was a problem hiding this comment.
Pull request overview
Adds MediaTek (MEDIATEK) platform support to MemCapture so the tool can collect CMA and GPU memory metrics on MediaTek devices.
Changes:
- Added
MEDIATEKto thePlatformenum and CLI--platformparsing / help text. - Extended
MemoryMetricto recognize MediaTek CMA region naming and fragmentation parsing expectations. - Implemented MediaTek Mali GPU memory parsing via
/sys/kernel/debug/mali0/gpu_memory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| main.cpp | Adds MEDIATEK to --platform usage text and argument parsing. |
| Platform.h | Extends Platform enum with MEDIATEK. |
| MemoryMetric.h | Declares MediaTek GPU memory collection method. |
| MemoryMetric.cpp | Adds MediaTek-specific CMA mapping, feature flags, fragmentation column count, and GPU memory parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added MEDIATEK Platform support
Test Procedure: please refer the ticket comments
Risks: Medium