Skip to content

test(reconcile): guard canonicalJSON number precision with a 2^53 pair #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 1 commit into from
Aug 14, 2026
Merged

test(reconcile): guard canonicalJSON number precision with a 2^53 pair #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/reconcile/metaschema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,13 @@ func TestCanonicalJSON(t *testing.T) {
assert.Error(t, err)
})
t.Run("keeps a real difference in a large integer", func(t *testing.T) {
a, err := canonicalJSON(`{"maximum":10000000000000001}`)
// 2^53+1 and 2^53 both round to 2^53 under a float64 decode, so this pair
// fails without the UseNumber decode and passes with it. A larger pair like
// 1e16+1 vs 1e16+2 would round to distinct floats and pass either way, so it
// would not guard the fix.
a, err := canonicalJSON(`{"maximum":9007199254740993}`)
assert.NoError(t, err)
b, err := canonicalJSON(`{"maximum":10000000000000002}`)
b, err := canonicalJSON(`{"maximum":9007199254740992}`)
assert.NoError(t, err)
assert.NotEqual(t, a, b)
})
Expand Down
Loading