Update lotus-mtg-companion extension#28404
Conversation
- Merge branch \'contributions/merge-1780018344281\' - Pull contributions - chore: format CardDetail and add changelog for DFC fix - Merge pull request raycast#2 from EggsLeggs/fix-card-detail-undefined-error - fix: handle double-faced cards in CardDetail to prevent TypeError crash - text: minor language update - misc: update package-lock - naming: update package.json name - Merge branch \'main\' of https://github.com/MadMaxMcKinney/raycast-mtg-companion - misc: minor text command update - Update README.md - readme: update with new content - feat: add View all cards in set Action - feat: add set search and produced_mana detail - icon: new design, new name - feat: improve recent card filtering - command: add randomCard - feature: added recent cards and more card data - init commit - Initial commit
|
Thank you for your first contribution! 🎉 🔔 @MadMaxMcKinney you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/lotus-mtg-companion"
FORK_URL="https://github.com/EggsLeggs/raycast-extensions.git"
EXTENSION_NAME="lotus-mtg-companion"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR fixes a crash in the Card Detail view when opening double-faced MTG cards (e.g., transform/modal cards) by gracefully falling back to
Confidence Score: 5/5The change is a targeted crash fix for double-faced cards with no new dependencies or API surface changes; all modifications are additive fallback logic. All changes are defensive — optional chaining, null coalescing, and type corrections that bring the interface in line with the actual Scryfall API. No existing happy-path behavior is altered. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Update extensions/lotus-mtg-companion/CH..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Looks good, appreciate the fix! |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder