1Password: Enable cross-field search#26952
Conversation
…ault name Search queries are now split by spaces and each token is matched independently against all item fields (title, username/email, URL hostnames, vault name). This allows queries like "m@ goo" to find a Google login with email m@example.com.
|
Thank you for your contribution! 🎉 🔔 @khasbilegt @thomaspaulmann @dteare @pernielsentikaer @cb372 @henrik-dmg @superwhys @Luk4h @LitoMore @vimtor @Pavelas @iml885203 you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="1password-cross-field-search"
FORK_URL="https://github.com/st0mich/extensions.git"
EXTENSION_NAME="1password"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR replaces Raycast's built-in
Confidence Score: 4/5Safe to merge after fixing the CHANGELOG date placeholder One P1 finding: the CHANGELOG entry uses a hardcoded date instead of the {PR_MERGE_DATE} placeholder required by repo convention. The search logic itself is correct and the implementation is consistent across v7 and v8. CHANGELOG.md needs the date placeholder corrected before merging. Important Files Changed
|
| @@ -1,5 +1,9 @@ | |||
| # 1Password Changelog | |||
|
|
|||
| ## [Enhancements] - 2026-04-05 | |||
There was a problem hiding this comment.
Hardcoded date instead of
{PR_MERGE_DATE} placeholder
Changelog entry titles must use {PR_MERGE_DATE} so the merge date is populated automatically during release. Using a hardcoded date means the changelog will be incorrect if the PR merges on a different day.
| ## [Enhancements] - 2026-04-05 | |
| ## [Enhancements] - {PR_MERGE_DATE} |
Rule Used: What: Changelog entries must use {PR_MERGE_DATE}... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/1password/CHANGELOG.md
Line: 3
Comment:
**Hardcoded date instead of `{PR_MERGE_DATE}` placeholder**
Changelog entry titles must use `{PR_MERGE_DATE}` so the merge date is populated automatically during release. Using a hardcoded date means the changelog will be incorrect if the PR merges on a different day.
```suggestion
## [Enhancements] - {PR_MERGE_DATE}
```
**Rule Used:** What: Changelog entries must use `{PR_MERGE_DATE}`... ([source](https://app.greptile.com/review/custom-context?memory=c2214c11-df56-490a-b1c0-09a385df481a))
How can I resolve this? If you propose a fix, please make it concise.
pernielsentikaer
left a comment
There was a problem hiding this comment.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@st0mich). Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag. |
Summary
Motivation
Previously, searching for a combination of email and service name returned no results because Raycast's built-in filtering only matched tokens within single fields. This made it hard to find specific logins when you remembered parts of both your email and the service name.
Implementation
Listfiltering with custommatchesSearch()that splits the query into tokens and checks each token against all searchable fields.filtering={false}andonSearchTextChangeonListto handle filtering manually.item.urlsto make domains searchable.Test plan