Skip to content

RavenDB-26793 Time-series bulk-insert UTC fix + custom-entity-name control-char guard #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poissoncorp merged 2 commits into from
Jul 9, 2026
Merged

RavenDB-26793 Time-series bulk-insert UTC fix + custom-entity-name control-char guard #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb360d
RavenDB-26793 Fix bulk-insert time-series timestamps to treat naive d…
poissoncorp Jul 8, 2026
af94dd8
RavenDB-26793 Skip all C0 control characters in custom-entity-name test
poissoncorp Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ravendb/tests/jvm_migrated_tests/client_tests/test_custom_entity_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ def _customize_store(self, store: DocumentStore) -> None:
)

def __test_when_collection_and_id_contain_special_chars(self, c: str) -> None:
if 14 <= ord(c) <= 31:
# RavenDB now rejects control characters in document ids (including the generated HiLo id),
# so skip the whole C0 control range rather than only 14..31.
if ord(c) <= 31:
return

self.c = c
Expand Down
6 changes: 5 additions & 1 deletion ravendb/tools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from collections import Iterable, Sequence

from ravendb.tools.projection import create_entity_with_mapper
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from enum import Enum
from threading import Timer
from copy import deepcopy
Expand Down Expand Up @@ -958,4 +958,8 @@ def add_minutes(date: datetime, minutes: int):

@staticmethod
def get_unix_time_in_ms(date: datetime) -> int:
# Naive datetimes are treated as UTC (consistent with Utils.datetime_to_string) so that
# bulk-insert time-series timestamps are not shifted by the machine's local UTC offset.
if date.tzinfo is None:
date = date.replace(tzinfo=timezone.utc)
return int(date.timestamp() * 1000)
Loading