hawkbit-client: poll in 10s if an activity was performed#204
Open
1NFR4R3D wants to merge 3 commits intorauc:masterfrom
Open
hawkbit-client: poll in 10s if an activity was performed#2041NFR4R3D wants to merge 3 commits intorauc:masterfrom
1NFR4R3D wants to merge 3 commits intorauc:masterfrom
Conversation
Check if `hawkbit_pull_cb()` performed any cancellation or download. If it performed either, set the interval to 10s instead of the configured value. Signed-off-by: Kanishkavikram Purohit <kpurohit@tewke.com>
1NFR4R3D
force-pushed
the
feature/poll-sooner-on-action
branch
from
3241393 to
14eab3e
Compare
Expanding on commit 14eab3e, allows overriding sleep time to a value from config file instead of the value provided by the server. Signed-off-by: Kanishkavikram Purohit <kpurohit@tewke.com>
1NFR4R3D
force-pushed
the
feature/poll-sooner-on-action
branch
from
12932b3 to
6f5764f
Compare
Author
|
Added the ability to control the override based on a config value instead of hard-coding it in |
Member
|
Processing multiple actions sounds like a good enhancement. Instead of adding another config option and polling the base resource again (which is strictly speaking against the DDI API's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
hawkbit_pull_cbin hawkbit-client.c handles only one action (download or cancellation) every time it runs.In cases where a device has many pending actions and has a sensible poll interval, the update is delayed for a significantly long time.
For instance, if a device has 6 updates assigned to it, of which 5 are cancelled and 1 is available for download, and it has been configured to poll the server every 15 minutes, it will take one hour and 15 minutes before it starts downloading the update.
While this isn't a problem for any devices in the field and online, it is a problem for devices that are either offline for a long period, or in our case, devices that have not been deployed yet.
Duplicate: #203