Reject a non-redis PROPERTY_DB scheme instead of a silent filesystem fall-back - #17
Merged
Merged
Conversation
…a directory Only an exact redis:// prefix was recognised; a rediss:// typo — or any other scheme — fell through to FilesystemCorpus and silently wrote the corpus to a directory named after the scheme, the exact silent filesystem fall-back the design forbids. Match the scheme case-insensitively (Redis:// is a shared corpus) and error on any non-redis scheme, naming the scheme but not the DSN (which may carry credentials). Fixes #13
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Only an exact
redis://prefix was recognised, sorediss://,Redis://or any other scheme fell through toFilesystemCorpusand silently wrote the corpus to a directory named after the scheme — the exact "silent fall back to the filesystem" the design forbids.Change
CorpusFromEnv::resolve()matches a leading URI scheme; a non-redisscheme throwsInvalidArgumentException. Scheme matching is case-insensitive, soRedis://is a shared corpus. The error names the scheme but not the DSN, which may carry credentials. A path with no scheme is unchanged.Redis://resolves to aRedisCorpus.Verification
composer buildgreen on core 0.4.1 — 93 tests, 2950 assertions.Sister issue
Same shared code in the Testo adapter: rasuvaeff/property-testing-testo#18 (fixed in lockstep).