Display uf2 combine --offset default-value in hexadecimal - #353
Open
lurch wants to merge 3 commits into
Open
Conversation
will-v-pi
reviewed
Aug 4, 2026
| ( | ||
| option("--offset").set(settings.uf2.offset_set) % "Offset second UF2 by amount" & | ||
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0)" | ||
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)" |
Contributor
There was a problem hiding this comment.
Maybe worth explicitly mentioning it is hexadecimal too?
Suggested change
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)" | |
| hex("offset").set(settings.uf2.offset) % "offset amount (hexadecimal, default to 0x0)" |
Contributor
Author
There was a problem hiding this comment.
Sorry, I somehow completely missed this comment! 🤦 (must have got buried under all my other GH notifications)
I've no objections to this, but note that there's many other example / default values listed in https://github.com/raspberrypi/picotool/blob/develop/README.md that start with 0x and that aren't explicitly stated to be hexadecimal.
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #352