Add pico_w/wifi/access_point_wifi_provisioning/#754
Conversation
peterharperuk
force-pushed
the
add_access_point_wifi_provisioning
branch
from
a181961 to
6716136
Compare
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
This doesn't seem to handle SSIDs with spaces correctly, because the form submission passes them as + instead, so it tries to connect to "My+Network" instead of "My Network". This might be an issue for other special characters too.
kilograham
left a comment
kilograham
left a comment
There was a problem hiding this comment.
un-approving to allow for will's comment
|
This example relies on this change raspberrypi/pico-sdk#3000 |
I'm still seeing the issue with SSIDs with spaces now that change has been merged - do SSIDs with spaces work for you? |
|
I haven't looked into that problem yet |
|
Oops... |
Fix compile warning. Use the same password as the other access point example. Fix captive portal
Only ever use one block Handle duplicates
Get rid of the submit button.
They seem to be answering requests on the network (oops).
Do this for safety. Plus some logging fixes
peterharperuk
force-pushed
the
add_access_point_wifi_provisioning
branch
from
6716136 to
be8ebc3
Compare
|
I fixed the issue with spaces in ssid names. But while testing it I realised the wifi connection logic wasn't reliable. We can't connect in a callback. I think this is fixed by moving the connecting to main. I've made other improvements. If we add this, it means we have another dhcpserver and dnsserver in the pico-examples tree which isn't ideal. I'm wondering whether I should just replace the existing access_point example with this one. Or leave the simpler one as it's easier to understand? I think I should get rid of the duplicate dhcp / dns servers though as I've fixed another bug like #382 where the dhcp server was handing out addresses on the network. |
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
Working now for me
I think we should keep the simpler example too, but de-duplication of the dhcp/dns servers would be useful at a later date - preferably not before this next release, as it will probably require some fixups to VS Code to handle copying in the dhcp/dns libraries into the generated examples
4 participants
No description provided.